New Release v1.27.0 - #minor #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When changing the language the timed layer where reset to their default time parameter. The issue is that only their current year where updated but not their current timestamp.
PB-637: Keep time layer selected year when changing the language
Somehow, probably due to an openlayer update, the print overlay was not anymore centered on the map on HiDPI and Retina devices (e.g. Iphone, Dell XPS 15, HP ZBook G9). After some test it turns out that the issue arised only when the DEVICE_PIXEL_RATIO was not 1. Removing this ratio from the computed print area solved the issue. This ratio in the print area has been introduced in 2014 in the old mf-geoadmin3 project (see geoadmin/mf-geoadmin3#1359) in order to solve the same issue observed here on HiDPI and Retina device. This issue has been probably solved internally in openlayers now.
PB-546: Print overlay not centered on high resolution device (e.g. Retina or HiDPI device)
When using CRTL + selection when we already had a drag selection, an uncaught exception occurred. Although everything seems to work fine, having uncaught exception is not so good. So now in order to avoid this exception we first need to remove the selection layer in every case before re-adding it if needed.
Fix uncaught exception when using drag selection
When panning the map moved faster than the cursor. This was due to the fact that default openlayer map interactions (like map panning) were added twice.
PB-633: Fix map panning being too fast
Sometimes the initial default print scale was under the header which is not so nice. This was due to the fact that the map is under the header and that during the scale computation we took only one header height in consideration but the print overlay is then center on the whole map, not only on the visible map. To avoid this issue we take twice the header size now.
PB-546: Improved default print scale computed from map size
1 failed test on run #2577 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > layer with timestamp can be configured |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #923 ↗︎
Issue : On mobile, small screen sizes could create issues where the head bar was partially inaccessible. In landscape mode it could appear under the header, which made it impossible to use, and in vertical mode, part of it was behind the right side menu. Fix : In landscape mode, we set the height of the tooltip to be the minimum between 350 pixels (previous value) and 60% of the viewport height, which ensure the head bar of the tooltip is never under the header. In vertical mode, if the width of the screen is smaller than 400 pixels, we enforce the feature info position to be set as 'bottompanel' and we remove the button to set it as a floating tooltip. This is called both when setting the info position and on resize.
Issue : We changed the way tooltips work on screen with narrow width. They can no longer float if the width is inferior to 400 pixels. This change caused some tests to fail. Fix : In most tests, we change the viewport to have a width of 400. In some tests, we also test that the application behaves as expected on devices with narrow width. Note: we skip one test for now, as it works locally but not on the CI.
We now only use the enum to check wether featureInfo is a valid value or not.
…in-mobile-mode PB-587: altering feature info behavior on mobile
pakb
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link