New Release v1.20.0 - #minor #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and activate it by default on desktop, with a button to let the user go back to the "sticky to feature" mode
Swapping the infobox minimize/expand button to caret based icons, and add a minimize/expand button to map popover Removing the button to change the popup mode (attached to feature or floating) and only show the tooltip as floating (even in drawing mode)
Shuffle the popup button to have the print "at the border" (will be removed for go-live) Filling the infobox entirely even if there's only one "set" of features Share networks : find a way to have them in one line in location popup, using a grid box to wrap (if necessary) instead of a flexbox, more resilient to wrapping
Placing it depending on mobile/desktop drawing elements, and adding checks at tooltip mount to make sure it is within the given limits. Exporting a bunch of extra SCSS variable and gathering them all in a single JS file to ease their imports down the line. Adding a bit of padding while editing a feature in the infobox (UI was glued to the border of the screen otherwise...)
as we want to test a profile edit, a very narrow screen (small height) is very cluttered and cannot really be tester properly
add a bit more padding to the edit feature in the infobox (matching the padding of the floating tooltip) force cursor to be a pointer over the feature list headers
…rt_2 PB-471 : add floating mode for tooltip
Currently on Cesium changing the year is removing/adding the layer which is not so nice when using the slider play feature as it result to a flickering effect. The way Cesium is configured don't allow us to do layer update. It seems that we could do it with a state management system but would required a big rewrite of 3D.
PB-518: Removed time slider on 3D view
using postMessage API to send the feature ID and layer ID of selected features to parent
if the app was embedded in an iframe with featureInfo=none in the URL, it is because this iframe shouldn't show any tooltip at all (and the user will managed feature selection through the postMessage API), so no reset is needed at first feature selection (it is essentially persistent)
with features given as null the code could break in some ways, here we make sure we have an array that contains something
…ction_event PB-506 : embed sends information to parent about selected features
For this I needed to be able to add/remove errors per layer as this error is only for 3D.
PB-505: Added error when external WMTS layer don't support WGS84
the old viewer also sends feature events when the map is added to an iframe without pointing to its "embed.html" page, so we have to mimic the same behavior. Now sending this postMessage event whenever a layer feature is selected
…ss_of_embed PB-506 : send feature event regardless of embed mode
The play button icon didn't reset to "play" after pausing the playing of the years
The data flow of the time slider was overly complicated and sometimes lead to triggering setting the same value twice. Tried to remodel the route that the data takes. Everything now more or less writes to the same computed property, which triggers setting the store if the data is correct. In my opinion, with this solution, there are less side effects and (almost) a single source of truth for the year. Two watchers could be eliminated.
The slider allows for selecting more years that are potentially available on all the displayed layers. When unmounting the slider, we shouldn't be setting the layers to invalid years.
Replace the simple time slider select with a searchable dropdown similar to the one in the provider urls
If the year cursor is moved, the store gets updated after a slight amount of time. But it isn't necessary to release the mouse anymore, the map will update when only the cursor is moved
Debounce the input year validation a bit so that the error isn't immediately shown when the user starts typing
…-on-tablets PB-501 Show dropdown for year selection in the time slider on tablet screens
a little omission on my part, the tooltip wasn't working since last changes made on the floating tooltip
PB-471 : fix 3D location popup
Passing run #2325 ↗︎
Details:
Review all test suite changes for PR #868 ↗︎ |
|||||||||||||||
The geolocation circle was not always on top of the map, if you added a new map then it covered the geolocation circle. Also simlified the z-index computation, always reserve the z-index for the elements even if they are not enabled, this make a code simpler and more robust.
Vue requires a template
The geolocation API might return a double number for the accuracy, in this case the accuracy was ignored. Now it is correctly set and if it is not a valid number an error is printed.
The geolocation tracking on non touch device was canceled as soon as the mouse moved on the map, even if not action was undertaken ! Now we use the setCenter to cancel the tracking, unless the setCenter is triggered by the geolocation. Also did some improvement using the geolocation API by allowing cached location and setting a timeout. Also when re-activating the geolocation we first set the previous location to make the app more reactive.
no empty divs in template use of our already implemented utils to detect if geolocation accuracy is a number
PB-521: fix geolocation tracking, zindex and accuracy and several geolocation improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link