-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Release v1.18.0 - #minor #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PB-486: Fix print area when map is rotated
…and active layers.
The 3d menu and geo catalogue menu entries where not the same height as the active menu items due to the missing compact class. Also with the compact class the buttons required the d-flex align-items-center class to be all aligned.
PB-491: 3D menu only when active
…xternal WMTS with time series Now the External WMTS are also working on 3d. Also added support for external WMTS with Time dimension, which can change the time dimension with the UI.
PB-496: External WMTS layer in 3d
…ayer PB-373: Fix missing label on GeoJSON layer
PB-489: Fix text offset
Issue : in some occasions, the router plugins would process the legacy query correctly, but not switch to the map view once it was done, staying stuck in the legacy view forever and not showing anything. This happened when there was no change to make to the query due to default parameters not being in the URL, but still needing a redirect to the map view. Fix : If we change the store and the view should change, we ask for a query change too
We need to be able to send the router to a 'next' route in some rare instances where the legacy parser was called, but there was no default parameter at all. To do this, we use an app parameter which is set to true by the legacy parser, and set to false the moment the store sync router makes a redirect. Also adding some debug logs
removing development logs moving logs where it makes sense to have them
…egacy view PB-447: removing legacy Usage checker linting log level change
PB-447: legacy parser not switching to map view
Now when clicking on play on the time slider the layer is updated and not removed/added which made a flickering effect.
PB-518: Fix timeslider flickering and WMS time enabled layer update
The striped bar was not satisfactory for conveying that there was only partial data available. Thus we now use a lighter shade of the primary color and added a tooltip to explain what the color means.
Part 1 : We fix the css here PB-442: update tippy translations
translation update
Tippy needs to be destroyed. Also avoid duplicate tippy content in code. For better readability use vue template for the complex tippy content. Fix margin issue with the play button introduced by `mx-1` class. Improve tippy content by adding some margin and padding.
…er-partial-data PB-442: change timeslider css for partial data
Passing run #2243 ↗︎
Details:
Review all test suite changes for PR #853 ↗︎ |
rebert
approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking forward to have a look on this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link