New Release v1.4.0 - #minor #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test link to PR to `develop-*` branches
Until we are on PROD we should not be allowed to edit KML that has been created by the old viewer, this means that in this case we should not move to the drawing menu automatically.
BGDIINF_SB-2685: Fixed legacy KML protection
Drawing while in 3D mode is not supported.
…tons-2 BGDIINF_SB-2890: Disable drawing menu when in 3D mode
This might introduce subtle bugs where we forgot to pass the correct projection. Better to make it mandatory and let the application crash with a backtrace when it is missing.
…the correct projection So there is no need to change it in componenent.
Made the geodesic component projection aware instead of hardcoding it to Web Mercator. This solve the bug when hovering the elevation profile the position was not tracked on the map.
…file During the drawing of the profile we need to sketch the point of the mouse. For this we did a wrap X coordinates, I don't know the reason why and it appears that it is not needed as open layer can handle both coordinates (wrapped and non wrapped), because this coordinate is only a temporary coordinate I think that is why it is not needed. Because to correctly wrap a coordinate you need to know in which projection you are and that in this event type you don't know it, I removed the wrap x for simplicity.
We still have an issue with the zoom level, but this might be solved by #471
BGDIINF_SB-2890: Fixed 3d to 2d center of map
…data This has been found while debugging e2e tests where the request intercept to the profile is done without data, it crash the application. Handle correctly such case when the api backend would malfunction to avoid any crash of the application.
In this one the projection was not correctly passed downward.
Now the coordinates from the service-alti api are rounded at two digits, therefore update the csv mocking in order to have the correct output.
…g_crash BGDIINF_SB-3146 : Fix: 3D drawing crash on camera move, disable 3D toggle button when draw
Reduced the timeout in order to speed tests when they are failings
On Chrome setting the `sr` query argument result to a primitive js `number` type and not a `Number` instance.
E2E tests are done in both projection so correctly intercept them.
Those test were written for Web Mercator and can only be run in this projection.
This to avoid timeout issue on this test on the CI.
The Geodesie test when running in browser make it crash using numTestsKeptInMemory higher than 2 !
…er-e2e-2 BGDIINF_SB-2890: Fixing geodesie tests
See code review comment.
BGDIINF_SB-3180: External Layer refresh attributes on reload
…-adr BGDIINF_SB-3180: Updated URL param ADR for the External Layers
I found that most (of not all) Cesium sandcastles (online examples) have this CSS rule to block touch action, it fixes all issues I experienced with panning while on a mobile device! I also de-activated the location popup (right-click) on mobile, as it wasn't very consistent how to trigger a right click with a touch screen.
…ents Improve mobile navigation in 3D
…nent Also fixed some linting and code styles issues.
…l layer script as in import tool This allow to make sure that our parsing works for all URL from our provider list.
…MS version Because we don't save anymore the WMS version in the URL we need to make sure that the server returns the version in its GetCapabilities.
Set the opacity and visibility of group of layers correctly (to all layers not only to the group object)
…-import BGDIINF_SB-3180: Use new Capabilities Parser for import tool
Because the advanced tool are not yet ready we remove it on productive environment.
Temporary remove the advanced tool menu on productive environment
github-actions
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will deploy on test.map.geo.admin.ch the same state as currently on sys-map.dev.bgdi.ch (the advance tool would be disabled on test.map.geo.admin.ch because the import tool is not yet production ready).
This deployment would totally remove the need of vectortiles that will not be available at the end of the month without a key.