Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BGDIINF_SB-3186: Added cypress cloud project ID for test parallelization #522

Merged
merged 8 commits into from
Dec 21, 2023

Conversation

ltshb
Copy link
Contributor

@ltshb ltshb commented Nov 8, 2023

@ltshb ltshb force-pushed the feat-BGDIINF_SB-3186-cy-cloud branch 3 times, most recently from 7b21065 to e48d586 Compare November 8, 2023 06:09
@ltshb ltshb force-pushed the feat-BGDIINF_SB-3186-cy-cloud branch from e48d586 to f443ce7 Compare November 8, 2023 07:44
@ltshb ltshb marked this pull request as draft November 8, 2023 08:21
@ltshb
Copy link
Contributor Author

ltshb commented Nov 8, 2023

We have to reduce the number of cypress it() before doing this, see BGDIINF_SB-3187

@ltshb ltshb force-pushed the feat-BGDIINF_SB-3186-cy-cloud branch 4 times, most recently from c87bfa0 to f61f3da Compare December 6, 2023 05:47
@ltshb ltshb force-pushed the feat-BGDIINF_SB-3186-cy-cloud branch 4 times, most recently from 0cf82d6 to 8cc71ac Compare December 13, 2023 18:09
Copy link

cypress bot commented Dec 13, 2023

Passing run #70 ↗︎

0 156 18 0 Flakiness 0

Details:

BGDIINF_SB-3186: Avoid flaky tests on cypress cloud
Project: web-mapviewer Commit: f31741ed3c
Status: Passed Duration: 02:55 💡
Started: Dec 21, 2023 9:40 AM Ended: Dec 21, 2023 9:43 AM

Review all test suite changes for PR #522 ↗︎

@ltshb ltshb force-pushed the feat-BGDIINF_SB-3186-cy-cloud branch 13 times, most recently from acee10f to c06a72a Compare December 14, 2023 14:40
@ltshb ltshb force-pushed the feat-BGDIINF_SB-3186-cy-cloud branch 3 times, most recently from 38e6cf3 to 963eee6 Compare December 18, 2023 16:12
When adding the cypress projectId, a vite deprecation warning appears when
running cypress. The warning lead to this page
https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated

And strangely the infobox.cy tests failed just by adding the projectId.

Moving to ESM syntax seems to solve the warning issue and cypress tests failure.
ESM syntax in eslint is not supported and its file needs to have the *.cjs
extension when `type: module` is set in package.json
This reporter is not compatible with ESM and is of no use now that we have
cypress cloud.
This key is needed in order to record cypress test on the cloud from your
local machine. This can be useful for debugging test that failed on the cloud
but not locally.
@ltshb ltshb force-pushed the feat-BGDIINF_SB-3186-cy-cloud branch 2 times, most recently from 45b861e to 35c4f44 Compare December 21, 2023 05:54
Somehow the realSwipe event of the cypress plugin doesn't work on cypress cloud.

Using the .trigger() as in https://github.com/cypress-io/cypress-example-recipes/blob/master/examples/testing-dom__drag-drop/cypress/e2e/drag_n_drop_spec.cy.js works with cypress cloud as well
as local.
@ltshb ltshb force-pushed the feat-BGDIINF_SB-3186-cy-cloud branch 2 times, most recently from 60d3f5a to a3d6777 Compare December 21, 2023 08:52
@ltshb ltshb marked this pull request as ready for review December 21, 2023 08:52
@ltshb ltshb requested a review from pakb December 21, 2023 08:52
Some tests that rely on clicking on the map requires that the map has been
fully rendered otherwise the test will failed. Somehow when using cypress cloud
it seems that the openlayer rendering is a bit delayed and some tests are therefore
failing.
@ltshb ltshb force-pushed the feat-BGDIINF_SB-3186-cy-cloud branch from a3d6777 to f31741e Compare December 21, 2023 09:36
Copy link
Contributor

@pakb pakb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ltshb ltshb merged commit bbae865 into develop Dec 21, 2023
5 checks passed
@ltshb ltshb deleted the feat-BGDIINF_SB-3186-cy-cloud branch December 21, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants