-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BGDIINF_SB-3186: Added cypress cloud project ID for test parallelization #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltshb
force-pushed
the
feat-BGDIINF_SB-3186-cy-cloud
branch
3 times, most recently
from
November 8, 2023 06:09
7b21065
to
e48d586
Compare
ltshb
force-pushed
the
feat-BGDIINF_SB-3186-cy-cloud
branch
from
November 8, 2023 07:44
e48d586
to
f443ce7
Compare
We have to reduce the number of cypress |
ltshb
force-pushed
the
feat-BGDIINF_SB-3186-cy-cloud
branch
4 times, most recently
from
December 6, 2023 05:47
c87bfa0
to
f61f3da
Compare
ltshb
force-pushed
the
feat-BGDIINF_SB-3186-cy-cloud
branch
4 times, most recently
from
December 13, 2023 18:09
0cf82d6
to
8cc71ac
Compare
Passing run #70 ↗︎
Details:
Review all test suite changes for PR #522 ↗︎ |
ltshb
force-pushed
the
feat-BGDIINF_SB-3186-cy-cloud
branch
13 times, most recently
from
December 14, 2023 14:40
acee10f
to
c06a72a
Compare
ltshb
force-pushed
the
feat-BGDIINF_SB-3186-cy-cloud
branch
3 times, most recently
from
December 18, 2023 16:12
38e6cf3
to
963eee6
Compare
When adding the cypress projectId, a vite deprecation warning appears when running cypress. The warning lead to this page https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated And strangely the infobox.cy tests failed just by adding the projectId. Moving to ESM syntax seems to solve the warning issue and cypress tests failure.
ESM syntax in eslint is not supported and its file needs to have the *.cjs extension when `type: module` is set in package.json
This reporter is not compatible with ESM and is of no use now that we have cypress cloud.
This key is needed in order to record cypress test on the cloud from your local machine. This can be useful for debugging test that failed on the cloud but not locally.
ltshb
force-pushed
the
feat-BGDIINF_SB-3186-cy-cloud
branch
2 times, most recently
from
December 21, 2023 05:54
45b861e
to
35c4f44
Compare
Somehow the realSwipe event of the cypress plugin doesn't work on cypress cloud. Using the .trigger() as in https://github.com/cypress-io/cypress-example-recipes/blob/master/examples/testing-dom__drag-drop/cypress/e2e/drag_n_drop_spec.cy.js works with cypress cloud as well as local.
ltshb
force-pushed
the
feat-BGDIINF_SB-3186-cy-cloud
branch
2 times, most recently
from
December 21, 2023 08:52
60d3f5a
to
a3d6777
Compare
Some tests that rely on clicking on the map requires that the map has been fully rendered otherwise the test will failed. Somehow when using cypress cloud it seems that the openlayer rendering is a bit delayed and some tests are therefore failing.
ltshb
force-pushed
the
feat-BGDIINF_SB-3186-cy-cloud
branch
from
December 21, 2023 09:36
a3d6777
to
f31741e
Compare
pakb
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow running tests on cypress.io, see also https://github.com/geoadmin/infra-terraform-bgdi-builder/pull/151
Test link