PB-984: avoid duplicate errors #1092
Conversation
ltkum
force-pushed
the
fix-PB-984-ensure-unicity
branch
from
363f179
to
d3c26e7
Compare
|
@sommerfe : since you're the one that found the issue, can you quickly check if you manage to reproduce it ? I might need to make a more thorough check on the params, since those are an object too. |
ltkum
force-pushed
the
fix-PB-984-ensure-unicity
branch
2 times, most recently
from
30360ba
to
ccd9edc
Compare
web-mapviewer
|
||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Run status |
|
| Run duration | 04m 26s |
| Commit |
|
| Committer | Martin Künzi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
211
|
ltkum
force-pushed
the
fix-PB-984-ensure-unicity
branch
from
ccd9edc
to
9f4b60a
Compare
|
When I import a KML file i still get a warning that i have to close 4 times to make it disappear, then a different one is visible that i can close with one click so maybe there is still something missing |
|
Now i don't get any warnings or errors when importing a KML file, is this correct or should there still be some warnings ? |
If you import a KML through the menu, there should be no errors / warnings. (sorry for the late answer, I was sick on friday) |
ltkum
force-pushed
the
fix-PB-984-ensure-unicity
branch
from
be77afb
to
9895ec2
Compare
Issue : sometimes, errors and warning might get added multiple times, and as they are new object instances, the set had issue ensuring unicity Fix : we filter the errors and warnings received, ensuring we only add messages with a different message AND different parameters. PB-984: putting equality check in class for easier readability can't filter aset
- We now dive into the params to check that they have the same length, the same keys, and the same values.
small issue with filtering
ltkum
force-pushed
the
fix-PB-984-ensure-unicity
branch
from
6907b89
to
629c9b1
Compare
Issue : sometimes, errors and warning might get added multiple times, and as they are new object instances, the set had issue ensuring unicity
Fix : we filter the errors and warnings received, ensuring we only add messages with a different message AND different parameters.
Test link