Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PB-984: quick fix for local layers #1087

Merged
merged 3 commits into from
Oct 8, 2024
Merged

PB-984: quick fix for local layers #1087

merged 3 commits into from
Oct 8, 2024

Commits on Oct 8, 2024

  1. PB-984: quick fix for local layers 

    Issue: when reloading the page, local layers trigger the error feedback, telling them they made a mistake, when technically they did not do anything wrong.

Fix : we assume local layers errors are due to actualisations / links sharing, and that we should warn the users they're trying to get a local file through the URL, which doesn't work, and gives them a feedback about it in the form of a warning.
    @ltkum
    ltkum committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    24e3e54 View commit details
    Browse the repository at this point in the history

  2. PB-984: translations and sending warnings instead of errors

    @ltkum
    ltkum committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    b804f74 View commit details
    Browse the repository at this point in the history

  3. PB-984: Not sending warnings when not necessary 

    Issue : in some cases, warnings or errors could be sent when unnecessary, as the router would loop more than once when mutations occur, and thus go through the URL query watcher. This was most visible with local external layers, which would be checked when not needed (for example, when switching from 2d to 3d).

Fix : If the value in the store is the same as the one in the query, we no longer validate the input.
    @ltkum
    ltkum committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    5c0d293 View commit details
    Browse the repository at this point in the history