Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PB-901: Modify name of KML file #1071

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

PB-901: Modify name of KML file #1071

wants to merge 8 commits into from

Commits on Oct 15, 2024

  1. PB-901: Modify name of KML file

    @sommerfe @pakb
    sommerfe authored and pakb committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    08795bb View commit details
    Browse the repository at this point in the history

  2. PB-901: modify name of KML file

    @sommerfe @pakb
    sommerfe authored and pakb committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    20c6b60 View commit details
    Browse the repository at this point in the history

  3. PB-901: always show kml input

    @sommerfe @pakb
    sommerfe authored and pakb committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    450d451 View commit details
    Browse the repository at this point in the history

  4. PB-901: fix lint

    @sommerfe @pakb
    sommerfe authored and pakb committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    9314cc8 View commit details
    Browse the repository at this point in the history

  5. PB-901: rename kml layer from start on

    @sommerfe @pakb
    sommerfe authored and pakb committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    8fe07e8 View commit details
    Browse the repository at this point in the history

  6. PB-901: keep layer name in component

    @sommerfe @pakb
    sommerfe authored and pakb committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    5c38adf View commit details
    Browse the repository at this point in the history

  7. PB-901 : disable drawing name input when no feature are drawn 

    Adding all relevant i18n keys for this new input.

Showing a tooltip (while disabling the input) telling the user it's not possible to change the drawing name while there is nothing drawn.
This was the easiest way of dealing with this input, as storing the value before a KML was present, or creating an empty one, was really complicated to manage down the line.

So by waiting for a KML (with at least a feature) to be present, we can safely change the KML name without having too much defensive code, or having to store the drawing name in Vuex (or move this part to the DrawingModule, changing a ton of things)
    @pakb
    pakb committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    754c82b View commit details
    Browse the repository at this point in the history

  8. WIP fix tests

    @pakb
    pakb committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    30d5bb9 View commit details
    Browse the repository at this point in the history