New Release v1.47.0 - #minor #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PB-859: Use the same approach to compute polygon area.
is way easier to find a key by its key this way...
Keep i18n file key alphabetically sorted
instead of using a "simple" matrix reprojection, which leads to a lack of accuracy the further we are from Bern (because LV03 to LV95 isn't a linear change)
rework of how coordinate are extracted from a string, so that it is now an async function (using the reframe service whenever LV03 coordinates are encountered) The coordinate parser now returns parsed coordinates without reprojection, with the coordinate system it was detected in alongside it.
but only return unreframed LV03 coordinate, and let the search store do the reframing after detecting it is LV03 coordinates. Should simplify the code of the extractor, removing the need for async there
should make the code much simpler to use in the context of the search bar
PB-843 : use LV03 to LV95 reframe services
It wasn't handled properly when a child component was declaring the ID itself, the parent MenuTray couldn't access the value of ID.
and add the language button as an extra button of this new section, so that it may be more easily accessed on mobile/touch devices.
select tags are insensitive to `text-align` prop on Safari, very old bug... So using another "technique" to have the text centered removing/refactoring most component that were previously used in both instances but are now distinct flavors
PB-788 : Mobile/tablet help menu section
Update from Master
Issue : When we were sending print requests, the scales of the symbols and texts in kmls were off. For icons, they were too small, and the texts were too big. Fix : We corrected the scales for icons and labels. Icons used a DPI adaptation of * 90 / 254 which was inherited from the old mapviewer. After some empirical testing, it looks like on the new mapviewer needs a *150 / 254 DPI adaptation Labels were not using the 'scale' parameter for the fonts at all, and they now also use a 150 / 254 DPI adaptation. It is important to note that the '254' given here is a computed value, as some layers will have smaller resolutions and their DPI will be used in those situations Still To Do : Text alignment and ensuring fonts are interpreted correctly on the print side. PB-818: offsets for the correct sizes Issue : with the scale being corrected for the icons and the fonts, the offsets were no longer correct. Thus, we adapt those offsets. small issue : I had to find ways to set the offsets in an empirical way, to ensure they were place at the correct spot. I'm going to investigate why it works, but for now it works.
Issue : Some of the changes made to handle scaling between print and viewer were using parameters that no longer exist in their previous form. Fix : We apply changes to the parameters we need to change, and take the new structure into account
…xture that is no longer valid small rebase correction
- Issue : the code was a bit hard to read in some places and some simplifications could be done. - Fix : We moved the magic number currently used in its own config, and created a config file for the print, and we simplified a few functions to make them easier to read. unordered import
- Added a check to ensure we operate correctly even if the dpi is not present. - Renamed a variable and updated a comment.
|
we must wait for geoadmin/service-icons#88 to be merged and deploy before going PROD |
…to-mapviewer PB-66: Add new babs icons to mapviewer
Or wait for @hansmannj to check with babs that everything is fine, in that case the service-icons image can be deployed without this PR |
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 01m 44s |
| Commit |
|
| Committer | Brice Schaffner |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
48
|
| View all changes introduced in this branch ↗︎ | |
- Issue : currently, there is only one error message existing at the same time, which means if a new error happens, it'll flush out the previous one, with no possibility of seeing it again. - Fix : We implement a queue, like for warnings, which means if multiple errors happen at the same time, we can check all of them.
PB-984: implement an error queue
Only support the kml file inside the KMZ.
Icons in kml can be inlined in href using base64 like this <IconStyle><Icon><href>data:image/png;base64,...</href></Icon></IconStyle> So such href cannot be passed to our proxy. Also to get the KML name and/or extent there is no need to proxify the icon urls, because icons won't be loaded during these methods.
PB-970: Add full support of KMZ file and fixed KML inlined icons #minor
ltshb
approved these changes
Sep 16, 2024
|
I tested drawing with babs icon on the tests link (using legacy babs icon and everything works as expecte) |
|
The CI test failure is due to cypress io flaky issue, and as I cannot re-start the CI manually unless we merge a new PR in develop, I'll bypass the branch protection |
|
Drawing with legacy babs icon:
Test with this release version of babs icons: 2 use cases depending on the icons listed by backend:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link