BGDIINF_SB-2430: Improved code based on code review

geoadmin · Oct 13, 2023 · bfec254 · bfec254
1 parent 3402ac1
commit bfec254
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/modules/menu/components/share/MenuShareEmbed.vue b/src/modules/menu/components/share/MenuShareEmbed.vue
@@ -191,7 +191,7 @@ export default {
     },
     computed: {
         embedPreviewModalWidth() {
-            // User the iframe with as maximal width for the embed preview modal window
+            // Uses the iframe's width as maximal width for the entire modal window
             return { 'max-width': this.iFrameWidth }
         },
         isPreviewSizeCustom() {

diff --git a/src/modules/menu/components/share/MenuShareInputCopyButton.vue b/src/modules/menu/components/share/MenuShareInputCopyButton.vue
@@ -1,6 +1,6 @@
 <template>
     <div v-if="inputText">
-        <label v-if="labelText">{{ labelText }}: </label>
+        <label v-if="labelText">{{ $t(labelText) }}: </label>
         <div class="input-group" :class="{ 'input-group-sm': small }">
             <input
                 type="text"

diff --git a/src/modules/menu/components/share/MenuShareSection.vue b/src/modules/menu/components/share/MenuShareSection.vue
@@ -13,7 +13,7 @@
             <MenuShareSocialNetworks :short-link="shortLink" class="pt-1" />
             <MenuShareInputCopyButton
                 :input-text="shortLink"
-                :label-text="$t('share_link')"
+                :label-text="'share_link'"
                 :copy-text="'copy_url'"
                 :copied-text="'copy_success'"
                 class="px-2 py-3"