PB-984: more torough check on equality

geoadmin · Oct 15, 2024 · 2ae7742 · 2ae7742
1 parent f30b0a4
commit 2ae7742
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/src/utils/ErrorMessage.class.js b/src/utils/ErrorMessage.class.js
@@ -13,11 +13,8 @@ export default class ErrorMessage {
         return (
             object instanceof ErrorMessage &&
             object.msg === this.msg &&
-            Object.keys(this.params).every(
-                (key) =>
-                    Object.keys(object.params).includes(key) &&
-                    this.params[key] === object.params[key]
-            )
+            Object.keys(this.params).length === Object.keys(object.params).length &&
+            Object.keys(this.params).every((key) => this.params[key] === object.params[key])
         )
     }
 }
diff --git a/src/utils/WarningMessage.class.js b/src/utils/WarningMessage.class.js
@@ -13,11 +13,8 @@ export default class WarningMessage {
         return (
             object instanceof WarningMessage &&
             object.msg === this.msg &&
-            Object.keys(this.params).every(
-                (key) =>
-                    Object.keys(object.params).includes(key) &&
-                    this.params[key] === object.params[key]
-            )
+            Object.keys(this.params).length === Object.keys(object.params).length &&
+            Object.keys(this.params).every((key) => this.params[key] === object.params[key])
         )
     }
 }