PB-63: Add new babs icons in all three languages #80
Conversation
LukasJoss
force-pushed
the
feat-PB-63-deploy-new-babs-icons
branch
2 times, most recently
from
59db179
to
c719541
Compare
LukasJoss
force-pushed
the
feat-PB-63-deploy-new-babs-icons
branch
2 times, most recently
from
3cf0334
to
ca4e8c9
Compare
LukasJoss
force-pushed
the
feat-PB-63-deploy-new-babs-icons
branch
from
ca4e8c9
to
514573f
Compare
| ) | ||
| self.assertEqual(width, expected_size) | ||
| if check_color: | ||
| if check_color: |
There was a problem hiding this comment.
What's the reason for no longer checking the correct icon size?
There was a problem hiding this comment.
Most babs icons are neither square nor is either of their side length equal to 48. Since the front end will need to be adapted anyway to properly display such icons this check can be removed since an icon set which conforms to these rules should be check during its creation by the owner of the icon set and not by the service
There was a problem hiding this comment.
I think, we need quadratic images, otherwise the dropdown gets messed up, right @pakb @boecklic ?
So, the idea would be, to resample non-quadratic svgs and convert them to quadratic pngs, while keeping the aspect ratio.
Just did a quick test using imagemagicks convert:
convert 030-D-EL.svg -resize 100x100 -background white -gravity center -extent 100x100 test.png seems to work well enough.
Probably the "100x100" needs to be adapted to something else, to make the result even "nicer".
Other option would be, to ask BABS to deliver all SVGs as square, e.g. by ensuring, that the white background canvas is quadratic, even if the colored symbol is not. No idea, if that would result in nicer converted pngs then.
Just noticed, that currently the BABS icons are transparent, while the new ones have a solid white background. Need to check with them.
Let's have a short discussion on this after the daily today. I'll need to contact BABS anyways to check on transparency, can check about the aspect ratio then, too.
There was a problem hiding this comment.
Maybe it could also be done in the build pipeline: https://www.npmjs.com/package/sharp
There was a problem hiding this comment.
Maybe the transparent background issue is due to the conversion tool I used. But let's have a short meeting anyways to clarify transparency, size and shape of the icons anyways.
No description provided.