Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI on PR #345

Closed
wants to merge 3 commits into from
Closed

CI on PR #345

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f131168
add pull_request to events that trigger make all
Aug 26, 2021
ba6341a
avoid hard-coding in the push branch
Aug 26, 2021
fbfa2f4
reverting all changes except event additions
Aug 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/make-all.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
on: push
name: make all

on:
push:
pull_request:
branches:
- master
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line LGTM, but I don’t think we need other changes

Copy link
Author

@nathanblair nathanblair Aug 26, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the checkout action does actually do a lot more in less lines in this case. I'm used to just issuing clone commands directly; forgot that action would handle figuring out refs for different events.

Let me tackle the revert of these other lines tomorrow morning.


jobs:
makeall:
name: make all
Expand All @@ -17,7 +23,7 @@ jobs:
shell: bash
- uses: actions/setup-go@v2
with:
go-version: '^1.13.1' # The Go version to download (if necessary) and use.
go-version: "^1.13.1" # The Go version to download (if necessary) and use.
- name: install go tools
run: |
go get golang.org/x/lint/golint
Expand Down