Skip to content

Commit

Permalink
remove packages preferences
Browse files Browse the repository at this point in the history
Signed-off-by: Arthur Zamarin <[email protected]>
  • Loading branch information
arthurzam committed May 20, 2024
1 parent 18e725e commit 7a4fa55
Show file tree
Hide file tree
Showing 10 changed files with 5 additions and 141 deletions.
Binary file removed assets/pgo1.png
Binary file not shown.
Binary file removed assets/pgo2.png
Binary file not shown.
7 changes: 1 addition & 6 deletions pkg/app/handler/packages/overview.templ
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package packages
import "slices"
import "strings"
import "time"
import "soko/pkg/app/handler/packages/components"
import "soko/pkg/app/utils"
import "soko/pkg/models"

Expand Down Expand Up @@ -133,7 +132,7 @@ templ maintainersList(maintainers []*models.Maintainer) {
}
}

templ overview(pkg *models.Package, userPreferences *models.UserPreferences) {
templ overview(pkg *models.Package) {
<div class="row">
<div class="col-md-9">
if len(pkg.Outdated) > 0 {
Expand Down Expand Up @@ -393,10 +392,6 @@ templ overview(pkg *models.Package, userPreferences *models.UserPreferences) {
}
</ul>
</div>
if userPreferences.Packages.Overview.Layout == "full" {
<div class="mt-4 pt-4"></div>
@components.Changelog(pkg.Atom, pkg.Commits)
}
</div>
<div class="col-md-3 pl-4 pt-4 mt-2">
<h4 class="mb-2 ml-1">
Expand Down
4 changes: 1 addition & 3 deletions pkg/app/handler/packages/show.go
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,7 @@ func Show(w http.ResponseWriter, r *http.Request) {

sortVersionsDesc(gpackage.Versions)

layout.Layout(gpackage.Atom, layout.Packages,
show(&gpackage, currentSubTab, utils.GetUserPreferences(r)),
).Render(r.Context(), w)
layout.Layout(gpackage.Atom, layout.Packages, show(&gpackage, currentSubTab)).Render(r.Context(), w)
}

func updateSearchHistory(atom string, w http.ResponseWriter, r *http.Request) {
Expand Down
4 changes: 2 additions & 2 deletions pkg/app/handler/packages/show.templ
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ func collectSecurityBugs(pkg *models.Package) (string, []*models.Bug) {
return pkg.Atom, bugs
}

templ show(pkg *models.Package, currentSubTab string, userPreferences models.UserPreferences) {
templ show(pkg *models.Package, currentSubTab string) {
if currentSubTab == "Reverse Dependencies" {
@tabbedHeader(pkg, "Dependencies")
} else {
Expand All @@ -156,7 +156,7 @@ templ show(pkg *models.Package, currentSubTab string, userPreferences models.Use
case "Reverse Dependencies":
@reverseDependencies(pkg)
default:
@overview(pkg, &userPreferences)
@overview(pkg)
}
</div>
</div>
Expand Down
100 changes: 0 additions & 100 deletions pkg/app/handler/user/packages.templ

This file was deleted.

2 changes: 0 additions & 2 deletions pkg/app/handler/user/preferences.templ
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ templ show(currentSubTab string, preferences models.UserPreferences) {
switch currentSubTab {
case "General":
@general(preferences.General)
case "Packages":
@packages(preferences.Packages)
case "Maintainers":
@maintainers(preferences.Maintainers)
}
Expand Down
3 changes: 0 additions & 3 deletions pkg/app/serve.go
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,6 @@ func Serve() {
setRoute("/user/preferences/general/layout", user.General)
setRoute("/user/preferences/general/reset", user.ResetGeneral)

setRoute("/user/preferences/packages/edit", user.EditPackagesPreferences)
setRoute("/user/preferences/packages/reset", user.ResetPackages)

setRoute("/user/preferences/maintainers/edit", user.Maintainers)
setRoute("/user/preferences/maintainers/reset", user.ResetMaintainers)

Expand Down
9 changes: 1 addition & 8 deletions pkg/app/utils/userdata.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,6 @@ func GetUserPreferences(r *http.Request) models.UserPreferences {
}
}

cookie, err = r.Cookie("userpref_packages")
if err == nil {
cookieValue, err := b64.StdEncoding.DecodeString(cookie.Value)
if err == nil {
json.Unmarshal(cookieValue, &userPreferences.Packages)
}
}

cookie, err = r.Cookie("userpref_maintainers")
if err == nil {
cookieValue, err := b64.StdEncoding.DecodeString(cookie.Value)
Expand All @@ -38,6 +30,7 @@ func GetUserPreferences(r *http.Request) models.UserPreferences {
}
}

// old cookie: userpref_packages
// old cookie: userpref_useflags
// old cookie: userpref_arches

Expand Down
17 changes: 0 additions & 17 deletions pkg/models/userpreferences.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,22 +4,13 @@ package models

type UserPreferences struct {
General GeneralPreferences
Packages PackagesPreferences
Maintainers MaintainersPreferences
}

type GeneralPreferences struct {
LandingPageLayout string
}

type PackagesPreferences struct {
Overview PackagesOverviewPreferences
}

type PackagesOverviewPreferences struct {
Layout string
}

type MaintainersPreferences struct {
IncludeProjectPackages bool
ExcludedProjects []string
Expand All @@ -31,14 +22,10 @@ var AllArches = [...]string{"alpha", "amd64", "arm", "arm64", "hppa", "ia64", "m
func GetDefaultUserPreferences() UserPreferences {
userPreferences := UserPreferences{}
userPreferences.General = GeneralPreferences{}
userPreferences.Packages = PackagesPreferences{}
userPreferences.Packages.Overview = PackagesOverviewPreferences{}
userPreferences.Maintainers = MaintainersPreferences{}

userPreferences.General.LandingPageLayout = "classic"

userPreferences.Packages.Overview.Layout = "minimal"

userPreferences.Maintainers.IncludeProjectPackages = false
userPreferences.Maintainers.ExcludedProjects = []string{}

Expand All @@ -51,8 +38,4 @@ func (u *UserPreferences) Sanitize() {
if !(u.General.LandingPageLayout == "classic" || u.General.LandingPageLayout == "full") {
u.General.LandingPageLayout = defaultUserPreferences.General.LandingPageLayout
}

if !(u.Packages.Overview.Layout == "minimal" || u.Packages.Overview.Layout == "full") {
u.Packages.Overview.Layout = defaultUserPreferences.Packages.Overview.Layout
}
}

0 comments on commit 7a4fa55

Please sign in to comment.