Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change delay to blocking on file io #207

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Change delay to blocking on file io #207

merged 4 commits into from
Oct 24, 2024

Conversation

mcanlas
Copy link
Contributor

@mcanlas mcanlas commented Oct 18, 2024

I believe blocking is the right constructor here, given the File IO?

By the way, what is the purpose of the defer below it? Isn't the parsing effect already suspended in F?

@mcanlas mcanlas requested a review from geirolz as a code owner October 18, 2024 19:42
@geirolz
Copy link
Owner

geirolz commented Oct 24, 2024

Thanks for the PR @mcanlas!
I agree with both

@geirolz geirolz merged commit bddf636 into geirolz:main Oct 24, 2024
3 of 4 checks passed
@mcanlas mcanlas deleted the blocking branch October 25, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants