feat(client-gen): .NET client code generator #611
+4,492
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DennisInSky
reviewed
Nov 11, 2024
| try | ||
| { | ||
| Libdl1.dlerror(); | ||
| UseLibdl1 = true; |
There was a problem hiding this comment.
Is there any special reason for not using libdl.so.2 all the time?
There was a problem hiding this comment.
supposing libdl[.dylib] is used in mac.
net/rs/client-gen-dotnet/Cargo.toml
Outdated
| crate-type = ["cdylib", "lib"] | ||
|
|
||
| [build-dependencies] | ||
| csbindgen.workspace = true |
There was a problem hiding this comment.
Really don't like as it introduces sort of circulr dependencies
There was a problem hiding this comment.
removed, but think it's better to generate code with csbindgen
| using global::System; | ||
| using global::System.Collections.Generic; | ||
|
|
||
| #pragma warning disable RCS0056 // A line is too long |
There was a problem hiding this comment.
Do we need this? Ananlyzers shouldn't check generated code
| ICall<global::Substrate.NetApi.Model.Types.Primitive.U8> DoThat(global::Substrate.NetApi.Model.Types.Base.BaseTuple<global::Substrate.NetApi.Model.Types.Primitive.U8, global::Substrate.NetApi.Model.Types.Primitive.U32> p1); | ||
| } | ||
|
|
||
| public partial class Basic : IBasic |
There was a problem hiding this comment.
Why is partial? Shouldn't it be sealed?
There was a problem hiding this comment.
it's good practice to make generated classes partial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.