TPA #2
Open
TPA #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YTG1234
commented
Nov 6, 2020
gdude2002
requested changes
Nov 6, 2020
|
How should I store the teleport requests? |
In-memory, I don't think persisting them would be useful. You really only need a mapping I'd say — UUID to request object. They should expire after 30 seconds or so as well. |
|
I think I pretty much implemented all of the needed functionality. Currently, the requests are stored in a weird map format and do not expire. |
|
With this weird UUID system if you request a teleport and had already requested it for that person it overwrites it, should I prevent that? The only way to delete a teleport request is to cancel it or deny it. |
Open
Co-authored-by: SpaceClouds42 <[email protected]>
Co-authored-by: SpaceClouds42 <[email protected]>
src/main/kotlin/me/gserv/fabrikommander/commands/TpaHereCommand.kt
Outdated
Show resolved
Hide resolved
…d.kt Co-authored-by: SpaceClouds42 <[email protected]>
…d.kt Co-authored-by: SpaceClouds42 <[email protected]>
Co-authored-by: SpaceClouds42 <[email protected]>
…d.kt Co-authored-by: SpaceClouds42 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is of course a draft PR because it's not done yet.