Skip to content

Commit

Permalink
adding specific condition for handled params in documentation test (g…
Browse files Browse the repository at this point in the history
  • Loading branch information
ahakanzn committed Aug 13, 2024
1 parent a64fa67 commit abdc50d
Showing 1 changed file with 17 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,13 @@
*/
package org.gbif.literature.resource;

import io.swagger.v3.oas.annotations.Parameter;

import org.gbif.api.model.literature.search.LiteratureSearchParameter;
import org.gbif.literature.search.LiteratureEsFieldMapper;

import java.util.Arrays;
import java.util.HashSet;
import java.util.Set;
import java.util.stream.Collectors;

Expand All @@ -30,18 +33,29 @@ public class LiteratureDocumentationTests {

@Test
public void searchParametersDocumented() {
Set documentedParameters =

Set<LiteratureSearchParameter> handledParams = new HashSet<>(
Arrays.asList(
LiteratureSearchParameter.DOI,
LiteratureSearchParameter.ADDED,
LiteratureSearchParameter.PUBLISHED,
LiteratureSearchParameter.DISCOVERED,
LiteratureSearchParameter.MODIFIED
)
);

Set<String> documentedParameters =
Arrays.stream(
LiteratureResource.CommonSearchParameters.class
.getAnnotation(Parameters.class)
.value())
.map(p -> p.name())
.map(Parameter::name)
.collect(Collectors.toSet());

LiteratureEsFieldMapper fieldMapper = new LiteratureEsFieldMapper();

for (LiteratureSearchParameter param : LiteratureSearchParameter.values()) {
if (param == LiteratureSearchParameter.DOI) {
if (handledParams.contains(param)) {
continue; // Handled specially.
}
String name = fieldMapper.get(param);
Expand Down

0 comments on commit abdc50d

Please sign in to comment.