feat: random entry

[dag7dev]

Description

• giving the usual endpoint API link, return a random entry, using the usual parameters
  Closes Play random entry #71

[avivace]

@dag7dev just an idea: maybe instead of ad-hoc endpoint random could simply be a query param that is available on the search endpoint? E.g.:

/search?random=true

[avivace]

Perfect! Just a minor comment to go ;)

[avivace]

Why are casting to int here? Pagination is already trying to the desired page here so if something is wrong (e.g. page is a string) it already fails there (and goes to page 1)

[dag7dev]

it will return a string otherwise, and... this is not consistent with the normal backend behavior

[avivace]

What? That's not true. At this line, page is used to paginate, if it's not a proper integer it would've failed there, so there's no way the code progress with page being a string.

[avivace]

Please also make sure to run pre-commit, as the checks are failing due to some unformatted file

[dag7dev]

Please also make sure to run pre-commit, as the checks are failing due to some unformatted file

not sure why it hasn't been ran automatically

[dag7dev]

I'm pretty sure about it. When I have some time, I will send a screenshot to clarify this

…

-------- Messaggio originale -------- 18/05/24 22:22, Antonio Vivace ha scritto:

@avivace commented on this pull request. --------------------------------------------------------------- In [hhub/views.py](#113 (comment)): > @@ -171,7 +174,7 @@ def search_entries(request): # total number of pages "page_total": paginator.num_pages, # current request page - "page_current": page, + "page_current": int(page), What? That's not true. At [this line](https://github.com/gbdev/homebrewhub/blob/main/hhub/views.py#L54), page is used to paginate, if it's not a proper integer it would've failed there, so there's no way the code progress with page being a string. — Reply to this email directly, [view it on GitHub] You are receiving this because you were mentioned.Message ID: ***@***.***>

[dag7dev]

@avivace take a look. This is without the "int"

Same goes for other nums obviously:

This is with it and intended:

[avivace]

Ah alright, I understood what you mean, it's on the way back on the response