Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statically-composable gzserver #631

Open
roncapat opened this issue Nov 4, 2024 · 1 comment
Open

Statically-composable gzserver #631

roncapat opened this issue Nov 4, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@roncapat
Copy link

roncapat commented Nov 4, 2024

Currently, no header file is defined for https://github.com/gazebosim/ros_gz/blob/ros2/ros_gz_sim/src/gzserver.cpp

This means that currently there is no possibility to import the node in a custom main.cpp to be statically composed with other nodes in the same process space, but the user is forced to go with dynamic composition.

The solution is fairly simple, and I may open a PR if you agree to add the header of this node and make it linkable from 3-rd party projects.

@roncapat roncapat added the enhancement New feature or request label Nov 4, 2024
@azeey
Copy link
Contributor

azeey commented Nov 4, 2024

I'm not opposed to this, but having a public header adds a constraint on how we can modify the GzServer class. If we do this, we should remedy this by using the PIMPL pattern via GZ_UTILS_UNIQUE_IMPL_PTR from gz-utils https://github.com/gazebosim/gz-utils/blob/gz-utils3/include/gz/utils/ImplPtr.hh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Inbox
Development

No branches or pull requests

2 participants