Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2D Bounding Box messages from bounding box cameras are not bridged #457

Closed
wittenator opened this issue Oct 27, 2023 · 9 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@wittenator
Copy link
Contributor

Desired behavior

There should be a bridge for the translation of 2D BBox messages coming from bounding box cameras.

Alternatives considered

None

Implementation suggestion

The corresponding ignition messages should be added. I did this in https://github.com/wittenator/ros_gz/tree/humble .

Additional context

This is useful if one wants to replace e.g. an object detection node that runs on CUDA-hardware only with a Gazebo bounding box camera to make the simulation run on any hardware.

@wittenator
Copy link
Contributor Author

@ahcorde Is the port to ROS Iron something the Ros_gz team will do or should I do another PR?

@ahcorde
Copy link
Collaborator

ahcorde commented Nov 9, 2023

@wittenator, if you want to take care of the forward port I really appreciate it otherwise I will do it this or next week.

@wittenator
Copy link
Contributor Author

Sure, I don't mind doing that. I'll probably come around to it on Monday tho

@wittenator
Copy link
Contributor Author

Ahh, do you know when to expect the changes reflected in the binary packages?

@ahcorde
Copy link
Collaborator

ahcorde commented Nov 9, 2023

I can make a release today, and changes will be available in the next humble sync.

@wittenator
Copy link
Contributor Author

The humble release is not urgent for me anymore, I switched to Iron in the meantime^^ I was just curious, but thanks for the info!

@wittenator
Copy link
Contributor Author

I added a PR to the Iron branch with the cherry-picked changes from the last merged PR in #460 .

@mjcarroll
Copy link
Collaborator

@ahcorde to close after rolling release

@mjcarroll mjcarroll assigned mjcarroll and ahcorde and unassigned mjcarroll Nov 20, 2023
@ahcorde
Copy link
Collaborator

ahcorde commented Nov 21, 2023

PR was forward ported to rolling too #466.

Closed. Thank you @wittenator for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

3 participants