Check camera sensors have non-zero width or height #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
ahcorde
approved these changes
Nov 11, 2024
|
https://github.com/Mergifyio backport ign-sensors6 gz-sensors7 gz-sensors8 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
Signed-off-by: Ian Chen <[email protected]> (cherry picked from commit aaef365) # Conflicts: # src/RgbdCameraSensor.cc # src/WideAngleCameraSensor.cc
8 tasks
mergify bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
Signed-off-by: Ian Chen <[email protected]> (cherry picked from commit aaef365) # Conflicts: # src/RgbdCameraSensor.cc
8 tasks
mergify bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
Signed-off-by: Ian Chen <[email protected]> (cherry picked from commit aaef365)
8 tasks
ahcorde
pushed a commit
that referenced
this pull request
Nov 11, 2024
Signed-off-by: Ian Chen <[email protected]> (cherry picked from commit aaef365) Co-authored-by: Ian Chen <[email protected]>
ahcorde
added a commit
that referenced
this pull request
Nov 11, 2024
) Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Ian Chen <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>
ahcorde
added a commit
that referenced
this pull request
Nov 11, 2024
) * Check camera resolution (#480) Signed-off-by: Ian Chen <[email protected]> (cherry picked from commit aaef365) Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Ian Chen <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Check to verify that camera sensors have non-zero width / height before creating the rendering cameras. The check prevents gz-sim from crashing and will output a more meaningful msg.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.