Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumps in ionic : ci_matching_branch/bump_ionic_gz-sensors9 #399

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Bumps in ionic : ci_matching_branch/bump_ionic_gz-sensors9 #399

merged 3 commits into from
Oct 17, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Oct 16, 2023

iche033
iche033 reviewed Oct 16, 2023
View reviewed changes
.github/ci/packages.apt Outdated Show resolved Hide resolved
@azeey azeey mentioned this pull request Oct 17, 2023
Closed
83 tasks
@azeey
Copy link
Contributor Author

azeey commented Oct 17, 2023

@osrf-jenkins run tests please

@azeey azeey marked this pull request as ready for review October 17, 2023 21:10
@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited
Loading

Codecov Report

Merging #399 (f8ec3e3) into main (d44b7dc) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is 50.00%.

❗ Current head f8ec3e3 differs from pull request most recent head 7d4b787. Consider uploading reports for the commit 7d4b787 to get more accurate results

@@           Coverage Diff           @@
##             main     #399   +/-   ##
=======================================
  Coverage   72.34%   72.34%           
=======================================
  Files          37       37           
  Lines        5052     5052           
=======================================
  Hits         3655     3655           
  Misses       1397     1397
Files Coverage Δ
src/CameraSensor.cc 75.49% <100.00%> (ø)
src/DepthCameraSensor.cc 70.90% <0.00%> (ø)

@iche033
Copy link
Contributor

iche033 commented Oct 17, 2023

windows build should be fixed by #392. Merged with main to retrigger CI

@azeey azeey merged commit b834d76 into main Oct 17, 2023
10 checks passed
@azeey azeey deleted the ci_matching_branch/bump_ionic_gz-sensors9 branch October 17, 2023 22:43
@azeey azeey mentioned this pull request Aug 22, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iche033 iche033 iche033 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azeey @iche033