-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update air sensor with air_speed.proto #374
Conversation
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@osrf-jenkins run tests please! |
We may have to wait for a nightly here, first. |
@osrf-jenkins run tests please! |
The nightlies ran about 3.5hrs ago, so rerunning @osrf-jenkins run tests please! |
Codecov Report
@@ Coverage Diff @@
## main #374 +/- ##
==========================================
- Coverage 72.63% 72.62% -0.01%
==========================================
Files 36 36
Lines 4948 4947 -1
==========================================
- Hits 3594 3593 -1
Misses 1354 1354
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI looks good
🎉 New feature
Summary
Required gazebosim/gz-msgs#365
Added
air_speed.proto
msgs. I was usingair_speed_sensor.proto
in older version to avoid breaking ABI, inmain
we can do things properlyChecklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.