Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update air sensor with air_speed.proto #374

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Aug 14, 2023

🎉 New feature

Summary

Required gazebosim/gz-msgs#365

Added air_speed.proto msgs. I was using air_speed_sensor.proto in older version to avoid breaking ABI, in main we can do things properly

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde self-assigned this Aug 14, 2023
@ahcorde ahcorde requested a review from iche033 as a code owner August 14, 2023 13:34
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Aug 14, 2023
@azeey azeey added the beta Targeting beta release of upcoming collection label Aug 14, 2023
@ahcorde
Copy link
Contributor Author

ahcorde commented Aug 14, 2023

@osrf-jenkins run tests please!

@mjcarroll
Copy link
Contributor

@osrf-jenkins run tests please!

We may have to wait for a nightly here, first.

@ahcorde
Copy link
Contributor Author

ahcorde commented Aug 15, 2023

@osrf-jenkins run tests please!

@azeey
Copy link
Contributor

azeey commented Aug 15, 2023

The nightlies ran about 3.5hrs ago, so rerunning

@osrf-jenkins run tests please!

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #374 (a23997a) into main (7bfc85a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head a23997a differs from pull request most recent head 94607fc. Consider uploading reports for the commit 94607fc to get more accurate results

@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
- Coverage   72.63%   72.62%   -0.01%     
==========================================
  Files          36       36              
  Lines        4948     4947       -1     
==========================================
- Hits         3594     3593       -1     
  Misses       1354     1354              
Files Changed Coverage Δ
src/AirSpeedSensor.cc 80.00% <100.00%> (-0.27%) ⬇️

Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI looks good

@iche033 iche033 merged commit 83f0e1f into main Aug 15, 2023
7 checks passed
@iche033 iche033 deleted the ahcorde/harmonic/update_air_speed_proto branch August 15, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🎵 harmonic Gazebo Harmonic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants