Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ignition #366

Merged
merged 3 commits into from
Aug 3, 2023
Merged

remove ignition #366

merged 3 commits into from
Aug 3, 2023

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jul 27, 2023

🎉 New feature

Removes ignition

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig requested a review from iche033 as a code owner July 27, 2023 12:33
@nkoenig nkoenig marked this pull request as draft July 27, 2023 12:34
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #366 (c407f35) into main (a516493) will not change coverage.
The diff coverage is n/a.

❗ Current head c407f35 differs from pull request most recent head 293a57d. Consider uploading reports for the commit 293a57d to get more accurate results

@@           Coverage Diff           @@
##             main     #366   +/-   ##
=======================================
  Coverage   72.63%   72.63%           
=======================================
  Files          36       36           
  Lines        4948     4948           
=======================================
  Hits         3594     3594           
  Misses       1354     1354           
Files Changed Coverage Δ
src/Lidar.cc 92.34% <ø> (ø)

Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig marked this pull request as ready for review August 2, 2023 12:22
@iche033 iche033 merged commit d649800 into main Aug 3, 2023
6 checks passed
@iche033 iche033 deleted the nkoenig/remove-ign branch August 3, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants