Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecations #365

Merged
merged 4 commits into from
Jul 25, 2023
Merged

Remove deprecations #365

merged 4 commits into from
Jul 25, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Jul 24, 2023

🎉 New feature

Summary

Remove functions that were deprecated in gz-sensors7. Also remove ignition headers.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from iche033 as a code owner July 24, 2023 22:05
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jul 24, 2023
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some suggestions here azeey#1

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #365 (0ff70cf) into main (51ac448) will increase coverage by 0.42%.
The diff coverage is 100.00%.

❗ Current head 0ff70cf differs from pull request most recent head 3d89b46. Consider uploading reports for the commit 3d89b46 to get more accurate results

@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
+ Coverage   72.20%   72.63%   +0.42%     
==========================================
  Files          36       36              
  Lines        4980     4948      -32     
==========================================
- Hits         3596     3594       -2     
+ Misses       1384     1354      -30     
Files Changed Coverage Δ
include/gz/sensors/Manager.hh 83.33% <ø> (ø)
include/gz/sensors/SensorFactory.hh 60.52% <ø> (ø)
src/SensorFactory.cc 100.00% <ø> (+75.00%) ⬆️
src/Manager.cc 100.00% <100.00%> (+34.28%) ⬆️
src/Sensor.cc 91.66% <100.00%> (+1.36%) ⬆️
src/Util.cc 85.00% <100.00%> (+10.00%) ⬆️

@azeey azeey merged commit a516493 into gazebosim:main Jul 25, 2023
3 checks passed
@azeey azeey deleted the remove_deprecations branch July 25, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants