Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Focal on Harmonic #364

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Disable Focal on Harmonic #364

merged 2 commits into from
Jul 25, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Jul 24, 2023

Summary

Harmonic only supports Jammy so removing Focal CI.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from iche033 as a code owner July 24, 2023 17:09
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jul 24, 2023
- name: Compile and test
id: ci
uses: gazebo-tooling/action-gz-ci@jammy
doxygen-enabled: true
Copy link
Contributor

@iche033 iche033 Jul 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this picked up a few doxygen warnings and builds are failing. Maybe we should fix those before enabling?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed warnings in ccec18d

Signed-off-by: Addisu Z. Taddese <[email protected]>
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #364 (c487474) into main (679c0b2) will increase coverage by 0.23%.
The diff coverage is n/a.

❗ Current head c487474 differs from pull request most recent head ccec18d. Consider uploading reports for the commit ccec18d to get more accurate results

@@            Coverage Diff             @@
##             main     #364      +/-   ##
==========================================
+ Coverage   71.97%   72.20%   +0.23%     
==========================================
  Files          38       36       -2     
  Lines        4871     4980     +109     
==========================================
+ Hits         3506     3596      +90     
- Misses       1365     1384      +19     
Files Changed Coverage Δ
include/gz/sensors/Manager.hh 83.33% <ø> (+1.51%) ⬆️

... and 31 files with indirect coverage changes

@azeey azeey merged commit 51ac448 into main Jul 25, 2023
6 checks passed
@azeey azeey deleted the azeey/remove_focal_ci branch July 25, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants