Fix CameraSensor to check if element is null before access #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Levi Armstrong <[email protected]>
Levi-Armstrong
force-pushed
the
fix/CameraSensor
branch
from
76c8991
to
6b511ed
Compare
ahcorde
approved these changes
Jul 20, 2023
ahcorde
requested changes
Jul 20, 2023
iche033
reviewed
Jul 20, 2023
Codecov Report
@@ Coverage Diff @@
## gz-sensors7 #361 +/- ##
============================================
Coverage 69.70% 69.71%
============================================
Files 36 36
Lines 3958 3959 +1
============================================
+ Hits 2759 2760 +1
Misses 1199 1199
|
ahcorde
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was try to use the
example/save_imagewhich segfaults during execution. In the CameraSensor it was failing to check if the sensor element was not null before accessing it.