5 ➡️ 6 (main)

[chapulina]

➡️ Forward port

Port ign-sensors5 to main

Branch comparison: main...ign-sensors5

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

[chapulina]

@iche033 , any insight about the GpuLidarTest failures on Homebrew?

[codecov]

Codecov Report

Merging #155 (3efd53e) into main (1014843) will increase coverage by 0.38%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
+ Coverage   77.51%   77.90%   +0.38%     
==========================================
  Files          24       24              
  Lines        2326     2394      +68     
==========================================
+ Hits         1803     1865      +62     
- Misses        523      529       +6     

Impacted Files	Coverage Δ
src/Sensor.cc	88.67% <79.48%> (-2.99%)	⬇️
src/CameraSensor.cc	77.06% <83.33%> (+0.57%)	⬆️
src/AirPressureSensor.cc	85.91% <100.00%> (+0.40%)	⬆️
src/AltimeterSensor.cc	88.23% <100.00%> (+0.28%)	⬆️
src/DepthCameraSensor.cc	74.27% <100.00%> (+0.43%)	⬆️
src/GpuLidarSensor.cc	88.31% <100.00%> (+0.15%)	⬆️
src/ImuSensor.cc	90.82% <100.00%> (+0.72%)	⬆️
src/Lidar.cc	72.34% <100.00%> (+0.14%)	⬆️
src/LogicalCameraSensor.cc	89.85% <100.00%> (+0.30%)	⬆️
src/MagnetometerSensor.cc	88.37% <100.00%> (+0.27%)	⬆️
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1014843...3efd53e. Read the comment docs.

[iche033]

I'm not very sure. I have an ign-rendering branch to see if it fixes the issue:
https://github.com/ignitionrobotics/ign-rendering/tree/lidar_depth_clamp

anyway we can start a custom homebrew build with this ign-rendering branch?

[chapulina]

anyway we can start a custom homebrew build with this ign-rendering branch?

Maybe creating a branch of homebrew-simulation that builds ign-rendering from source from your branch and uses that for ign-sensors6, then open a PR and trigger CI here?

https://build.osrfoundation.org/job/ignition_sensors-ci-pr_any-homebrew-amd64/build

Not sure if it would work

[chapulina]

@iche033 , how about getting this in and debugging the lidar issues later?

[iche033]

I can't reproduce the homebrew test failures on ubuntu so not sure what's going on. I've ticketed issue #157 so we don't block this merge forward.