-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update heightmap size & added DEM example #560
Conversation
Signed-off-by: Jenn Nguyen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice demo works for me.
One suggestion is to keep the arguments to the heightmap example consistent with other examples, i.e.
./heightmap [engine_name] [graphics_api]
One idea would be to look for an --dem
arg, e.g.
# I think your code will pick ogre 1.x by default - maybe useful to add a msg about this
./heightmap --dem
# same behavior as above
./heightmap ogre --dem
# tries to use ogre2 with dem
./heightmap ogre2 --dem
# tries to use ogre2 + metal with dem
./heightmap ogre2 metal --dem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The demo works for me too. I like @iche033 's suggestions for the example's arguments.
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've addressed mine and @iche033 's comments. I think this is good to go!
@osrf-jenkins run tests please! |
Ahh, merging into #539 so we only iterate on CI in one place |
🦟 Bug fix
Requires gazebosim/gz-common#292
Summary
Updated
heightmapSizeZ
calculation, which was not ported from gazebo-classic. Thanks to @iche033.Also updated heightmap example to include DEMs:
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.