Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix msvc warning (#250) #262

Merged
merged 1 commit into from
May 28, 2024
Merged

Fix msvc warning (#250) #262

merged 1 commit into from
May 28, 2024

Conversation

Crola1702
Copy link
Contributor

🦟 Bug fix

Backport of #250

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@azeey @Crola1702
Fix msvc warning (#250)
dd2d736 
Signed-off-by: Addisu Z. Taddese <[email protected]>
@Crola1702 Crola1702 requested review from azeey and Blast545 May 28, 2024 14:11
@Crola1702 Crola1702 requested a review from nkoenig as a code owner May 28, 2024 14:11
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label May 28, 2024
azeey
azeey approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use Rebase and merge since this is a backport.

@Crola1702 Crola1702 merged commit e2a18dd into ign-launch5 May 28, 2024
9 of 10 checks passed
@Crola1702 Crola1702 deleted the Crola1702/7_to_5-28_05_2024 branch May 28, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeey azeey azeey approved these changes

@Blast545 Blast545 Awaiting requested review from Blast545

@nkoenig nkoenig Awaiting requested review from nkoenig nkoenig is a code owner

Assignees
No one assigned
Labels
🏯 fortress Ignition Fortress
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Crola1702 @azeey