Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package.xml, remove dependency on python3-yaml, and disable failing windows tests #249

Merged
merged 5 commits into from
May 1, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Mar 18, 2024

🎉 New feature

Summary

Add package.xml based on dependencies found in .github/ci/packages.

I didn't find any use of python3-yaml, so I've removed it from .github/ci/packages.apt.

This is to test out using vendor packages to provide Gazebo packages to ROS users (see gazebo-tooling/release-tools#1117).

@azeey azeey requested a review from nkoenig as a code owner March 18, 2024 23:04
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.62%. Comparing base (3fb524c) to head (076f4d1).
Report is 3 commits behind head on gz-launch7.

❗ Current head 076f4d1 differs from pull request most recent head 3d73c96. Consider uploading reports for the commit 3d73c96 to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##           gz-launch7     #249      +/-   ##
==============================================
+ Coverage       57.80%   58.62%   +0.81%     
==============================================
  Files               4        3       -1     
  Lines             429      423       -6     
==============================================
  Hits              248      248              
+ Misses            181      175       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azeey azeey changed the title Add package.xml and remove dependency on python3-yaml Add package.xml, remove dependency on python3-yaml, and disable failing windows tests Apr 26, 2024
@azeey azeey merged commit 6459072 into gz-launch7 May 1, 2024
9 checks passed
@azeey azeey deleted the azeey/package_xml branch May 1, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants