Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6 ➡️ 5 Backport to fix #636 #641

Merged
merged 1 commit into from
Sep 23, 2024
Merged

6 ➡️ 5 Backport to fix #636 #641

merged 1 commit into from
Sep 23, 2024

Commits on Sep 23, 2024

  1. Fix AssimpLoader collada texture coordinates (#634) 

    Fixes UNIT_AssimpLoader_TEST with assimp 5.4.3. This should fix homebrew CI.

This PR tweaks the way we checks for texture coordinates from assimp. Empty texture coordinate slots are now allowed as of assimp/assimp#5636. The new logic should be compatible with assimp 5.4.3 and prior versions

Signed-off-by: Ian Chen <[email protected]>
    @iche033 @Crola1702
    iche033 authored and Crola1702 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    df5f965 View commit details
    Browse the repository at this point in the history