Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data race issue in VHACD found by TSAN #612

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jun 18, 2024

🦟 Bug fix

Summary

VHACD can be run multi-threaded, and TSAN picked up a data race issue:

SUMMARY: ThreadSanitizer: data race <path_to_gz-common>/graphics/src/VHACD/VHACD.h:5985:15 in VHACD::VoxelHull::VoxelHull(VHACD::VoxelHull const&, VHACD::SplitAxis, unsigned int)

Changing to an atomic type fixes the problem.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 requested a review from marcoag as a code owner June 18, 2024 18:00
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels Jun 18, 2024
@iche033 iche033 merged commit 1ffd6ef into gz-common5 Jun 21, 2024
12 checks passed
@iche033 iche033 deleted the tsan_vhacd branch June 21, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants