Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pessimizing move #593

Merged
merged 4 commits into from
Apr 10, 2024
Merged

Remove pessimizing move #593

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6517106
Fix bazel build
shameekganguly Apr 10, 2024
46dc856
Merge branch 'gz-common5' into bazel
shameekganguly Apr 10, 2024
27f8288
Remove pessimizing move
mjcarroll Apr 10, 2024
aa211c0
Merge branch 'gz-common5' into mjcarroll/pessimizing_move
ahcorde Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions graphics/src/MeshManager_TEST.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,8 +304,8 @@ TEST_F(MeshManager, ConvexDecomposition)
std::size_t maxConvexHulls = 4;
std::size_t resolution = 1000;
auto submesh = boxMesh->SubMeshByIndex(0u).lock();
auto decomposed = std::move(common::MeshManager::ConvexDecomposition(
*(submesh.get()), maxConvexHulls, resolution));
auto decomposed = common::MeshManager::ConvexDecomposition(
*(submesh.get()), maxConvexHulls, resolution);

// Decomposing a box should just produce a box
EXPECT_EQ(1u, decomposed.size());
Expand Down
Loading