Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport MeshManager changes for doing convex decomposition #591

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Apr 8, 2024

➡️ Forward port

Backport MeshManager's ConvexDecomposition (#585) and MergeSubMeshes (#588) functions that are used for doing convex decomposition.

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

@iche033 iche033 requested a review from marcoag as a code owner April 8, 2024 20:51
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels Apr 8, 2024
@azeey
Copy link
Contributor

azeey commented Apr 8, 2024

We usually do Rebase merge for backports.

@iche033 iche033 merged commit cd159c2 into gz-common5 Apr 8, 2024
14 checks passed
@iche033 iche033 deleted the convex_decomposition_5 branch April 8, 2024 21:35
@iche033
Copy link
Contributor Author

iche033 commented Apr 8, 2024

We usually do Rebase merge for backports.

yep done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants