Drop the internal vendored version of TinyXML2 #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Steve Peters <[email protected]> Signed-off-by: Steve Peters <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #542 +/- ##
==========================================
- Coverage 83.63% 83.63% -0.01%
==========================================
Files 79 79
Lines 10213 10211 -2
==========================================
- Hits 8542 8540 -2
Misses 1671 1671
|
scpeters
reviewed
Oct 13, 2023
Signed-off-by: Michael Carroll <[email protected]>
…into mjcarroll/drop_vendor_tinyxml2
Signed-off-by: Michael Carroll <[email protected]>
scpeters
reviewed
Nov 9, 2023
Signed-off-by: Michael Carroll <[email protected]>
scpeters
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All platforms have decently-supported TinyXML2 packages, so we have no need to vendor it anymore.