Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only build mesh integration tests if graphics libraries are built #523

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

mjcarroll
Copy link
Contributor

🦟 Bug fix

Fixes #522

Summary

This removes mesh.cc if the graphics component is not built either by being disabled by the user or from missing dependencies.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@mjcarroll mjcarroll requested a review from marcoag as a code owner July 12, 2023 14:04
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #523 (614a165) into gz-common5 (6a0f9d7) will not change coverage.
The diff coverage is n/a.

❗ Current head 614a165 differs from pull request most recent head ab262e5. Consider uploading reports for the commit ab262e5 to get more accurate results

@@             Coverage Diff             @@
##           gz-common5     #523   +/-   ##
===========================================
  Coverage       83.65%   83.65%           
===========================================
  Files              90       90           
  Lines           10249    10249           
===========================================
  Hits             8574     8574           
  Misses           1675     1675           

@Ryanf55
Copy link
Contributor

Ryanf55 commented Jul 12, 2023

LGTM, it works.

@mjcarroll mjcarroll merged commit 5f240a5 into gz-common5 Jul 12, 2023
@mjcarroll mjcarroll deleted the mjcarroll/check_integration_targets branch July 12, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

gz-common5 compile error: ColladaLoader.hh: No such file or directory
4 participants