Use common pkger #96
Merged
Use common pkger #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastien-gatling
force-pushed
the
misc-445-use-common-pkger
branch
from
4c51a7e
to
4fc07c6
Compare
slandelle
requested changes
Jan 30, 2024
src/main/groovy/io/gatling/gradle/GatlingEnterprisePackageTask.groovy
Outdated
Show resolved
Hide resolved
src/main/groovy/io/gatling/gradle/GatlingEnterprisePackageTask.groovy
Outdated
Show resolved
Hide resolved
src/main/groovy/io/gatling/gradle/GatlingEnterprisePackageTask.groovy
Outdated
Show resolved
Hide resolved
src/main/groovy/io/gatling/gradle/GatlingEnterprisePackageTask.groovy
Outdated
Show resolved
Hide resolved
| basePluginExtension.libsDirectory.get().asFile.getAbsolutePath(), | ||
| project.name + | ||
| jarVersion + | ||
| '-' + ARCHIVE_CLASSIFIER + |
There was a problem hiding this comment.
Just to be sure: does this generate the same file name as before?
There was a problem hiding this comment.
Actually, that's my intention. I started to map what you done in the maven plugin (with the .shaded.jar extension) and the integration tests were no longer passing.
So I reproduce the name schema of the AbstractArchiveTask that the previous task inherit before.
Now, IT still ok, and there is the version before de tests classifier when a version is defined.
bastien-gatling
force-pushed
the
misc-445-use-common-pkger
branch
from
4716853
to
893522f
Compare
slandelle
approved these changes
Jan 30, 2024
bastien-gatling
force-pushed
the
misc-445-use-common-pkger
branch
from
893522f
to
a570f25
Compare
guilgaly
approved these changes
Jan 31, 2024
|
@bastien-gatling Please rebase. Merge then? |
bastien-gatling
force-pushed
the
misc-445-use-common-pkger
branch
from
a570f25
to
cde9c2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.