feat: distinguish API URL from web app URL #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilgaly
commented
Sep 19, 2024
Comment on lines
+45
to
59
| def setApiUrl(String apiUrl) { | ||
| this.apiUrl = apiUrl | ||
| } | ||
|
|
||
| def url(String url) { | ||
| setUrl(url) | ||
| def apiUrl(String apiUrl) { | ||
| setApiUrl(apiUrl) | ||
| } | ||
|
|
||
| def setWebAppUrl(String webAppUrl) { | ||
| this.webAppUrl = webAppUrl | ||
| } | ||
|
|
||
| def webAppUrl(String webAppUrl) { | ||
| setWebAppUrl(webAppUrl) | ||
| } |
There was a problem hiding this comment.
Not backwards-compatible (changes the name used in the build.gradle file), but this setting was never documented for end users.
slandelle
approved these changes
Sep 19, 2024
notdryft
force-pushed
the
refactor-options
branch
from
9bf83cc
to
e085100
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.