Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm version from toolchain names #73

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

garymm
Copy link
Owner

@garymm garymm commented Sep 9, 2023

we only use one version of each so this is simpler

Change-Id: Iac008c1403710966bca47db958e627c7b079ea26

we only use one version of each so this is simpler

Change-Id: Iac008c1403710966bca47db958e627c7b079ea26
@garymm garymm marked this pull request as ready for review September 9, 2023 02:45
@oliverlee
Copy link
Collaborator

I tried out using squash merge for a project over the summer and it was nice how it creates a link to the PR in the commit message. Have you tried that?

@oliverlee oliverlee changed the title rm version form toolchain names rm version from toolchain names Sep 11, 2023
@garymm garymm merged commit d90fd30 into master Sep 11, 2023
14 checks passed
@garymm garymm deleted the Iac008c1403710966bca47db958e627c7b079ea26 branch September 11, 2023 17:15
@garymm
Copy link
Owner Author

garymm commented Sep 11, 2023

Yeah that's what we use by default at work.

@oliverlee
Copy link
Collaborator

Do you know if it works well with
multiple PRs and automerge?

@garymm
Copy link
Owner Author

garymm commented Sep 12, 2023

I don't know, we should try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants