Use iterator_interface in base_view::iterator definition
#64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garymm
approved these changes
Jun 16, 2023
oliverlee
force-pushed
the
I8fe5c4b00a905d60621e84f5396df90668d307a5
branch
2 times, most recently
from
c6f4d00
to
c979ec4
Compare
oliverlee
force-pushed
the
I2c9d14705bd5a0d8f7e562006913906d40c7fe86
branch
from
52f27b3
to
555ae92
Compare
oliverlee
force-pushed
the
I8fe5c4b00a905d60621e84f5396df90668d307a5
branch
from
c979ec4
to
b8faab5
Compare
Base automatically changed from
I2c9d14705bd5a0d8f7e562006913906d40c7fe86
to
master
June 26, 2023 00:26
Define `huffman::detail::iterator_interface`, a CRTP helper class to synthesize boiler-plate operations necessary to model `std::random_access_iterator`. This allows `detail::base_view::iterator` to define only the necessary basis operations, as well simplifying the implementation of `bit_span::iterator` in a future commit. Change-Id: I8fe5c4b00a905d60621e84f5396df90668d307a5
oliverlee
force-pushed
the
I8fe5c4b00a905d60621e84f5396df90668d307a5
branch
from
b8faab5
to
85e4576
Compare
garymm
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define
huffman::detail::iterator_interface, a CRTP helper class tosynthesize boiler-plate operations necessary to model
std::random_access_iterator. This allowsdetail::base_view::iteratorto define only the necessary basis operations, as well simplifying the
implementation of
bit_span::iteratorin a future commit.Change-Id: I8fe5c4b00a905d60621e84f5396df90668d307a5