use clang for coverage #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Clang when generating coverage data. It is faster than GCC and reports higher branch coverage. Coverage reports are now generated with `lcov` rules and CI is updated to use `//tools:lcov_list`. Change-Id: I84311f28070a13520684349e8e4ebfb538a7d002
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #119 +/- ##
===========================================
- Coverage 97.54% 81.48% -16.07%
===========================================
Files 15 2 -13
Lines 408 54 -354
Branches 0 8 +8
===========================================
- Hits 398 44 -354
+ Misses 10 6 -4
- Partials 0 4 +4 ☔ View full report in Codecov by Sentry. |
oliverlee
force-pushed
the
I84311f28070a13520684349e8e4ebfb538a7d002
branch
from
cbae15d
to
3477bff
Compare
|
test coverage has decreased but I think that was due to a mistake in the target specifications |
this commit now adds branch coverage data which did not exist before. codecov is now considering some lines partially covered when it used to consider them fully covered. |
oliverlee
commented
Dec 24, 2023
Comment on lines
-14
to
-19
| coverage --strategy=CoverageReport=local | ||
| # At least some of this is needed for the coverage tool to work. | ||
| coverage --experimental_split_coverage_postprocessing | ||
| coverage --experimental_fetch_all_coverage_outputs | ||
| coverage --remote_download_outputs=all | ||
| coverage --experimental_remote_download_regex=.*/((testlogs/.*/_coverage/.*)|coverage.dat$|_coverage/_coverage_report.dat$) |
There was a problem hiding this comment.
we may want to keep these 5 lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Clang when generating coverage data. It is faster than GCC and
reports higher branch coverage.
Coverage reports are now generated with
lcovrules and CI is updatedto use
//tools:lcov_list.Change-Id: I84311f28070a13520684349e8e4ebfb538a7d002