fix decode test after always using DEFLATE canonicalization #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #115 +/- ##
=======================================
Coverage 97.79% 97.79%
=======================================
Files 15 15
Lines 408 408
=======================================
Hits 399 399
Misses 9 9 ☔ View full report in Codecov by Sentry. |
oliverlee
force-pushed
the
I5dca691416482ae27ab31bc176fd5217b8e3fd8f
branch
from
5f2a504
to
5482af4
Compare
oliverlee
force-pushed
the
Ic46cbcee812f5812ab55f446c7d05c0e9e9d3e8a
branch
2 times, most recently
from
081149b
to
53838f7
Compare
oliverlee
force-pushed
the
I5dca691416482ae27ab31bc176fd5217b8e3fd8f
branch
from
5482af4
to
b15303a
Compare
oliverlee
force-pushed
the
Ic46cbcee812f5812ab55f446c7d05c0e9e9d3e8a
branch
from
53838f7
to
96718f6
Compare
garymm
approved these changes
Nov 22, 2023
huffman/test/decode_test.cpp
Outdated
| static constexpr auto expected = std::array{'e'}; | ||
|
|
||
| constexpr auto decoded = [] { | ||
| constexpr auto encoded = std::array<std::byte, 1>{}; |
There was a problem hiding this comment.
Zero initialized I assume?
Might be clearer to write the zero explicitly.
There was a problem hiding this comment.
It default constructs the array with default constructed Ts.
Sure I can do that.
oliverlee
force-pushed
the
I5dca691416482ae27ab31bc176fd5217b8e3fd8f
branch
from
b15303a
to
0803a3a
Compare
Base automatically changed from
I5dca691416482ae27ab31bc176fd5217b8e3fd8f
to
master
November 23, 2023 01:32
garymm
force-pushed
the
Ic46cbcee812f5812ab55f446c7d05c0e9e9d3e8a
branch
from
96718f6
to
4805678
Compare
garymm
force-pushed
the
Ic46cbcee812f5812ab55f446c7d05c0e9e9d3e8a
branch
from
4805678
to
8443d50
Compare
Update decode test to construct a table in canonical form and fix the associated test. This commit also adds additional decode test cases. Change-Id: Ic46cbcee812f5812ab55f446c7d05c0e9e9d3e8a
garymm
force-pushed
the
Ic46cbcee812f5812ab55f446c7d05c0e9e9d3e8a
branch
from
8443d50
to
354ef0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update decode test to construct a table in canonical form and fix the
associated test. This commit also adds additional decode test cases.
Change-Id: Ic46cbcee812f5812ab55f446c7d05c0e9e9d3e8a