Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Add Dev Container #991

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

enrico-kaack-comp
Copy link
Contributor

@enrico-kaack-comp enrico-kaack-comp commented Feb 28, 2024

What this PR does / why we need it:

Adds .devcontainer including all required tools and components for a full dev container including minikube and registry.
NOTE: not yet completed.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

@enrico-kaack-comp enrico-kaack-comp self-assigned this Feb 28, 2024
@enrico-kaack-comp enrico-kaack-comp requested a review from a team as a code owner February 28, 2024 14:30
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Feb 28, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 28, 2024
@enrico-kaack-comp enrico-kaack-comp marked this pull request as draft February 28, 2024 14:32
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 29, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 29, 2024
@enrico-kaack-comp enrico-kaack-comp changed the title Add Dev Container [Draft] Add Dev Container Feb 29, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 1, 2024
@enrico-kaack-comp
Copy link
Contributor Author

Performance Checks on M2 Pro 16GB:

Local Run:
55s Local landscaper-controller run without cluster, deleted cache
20s subsequent run without cluster, with cache

Colima Docker DevContainer with 8CPU/12GB
3m Landscaper controller run with minikube
1m 7s subsequent run with miniklube

--> 3x slower build compared to local

Suggestion: Scripts to setup a local minikube, registry (without TLS), create a kubeconfig, create target, create context.
Then the build is as fast as possible and the local setup is easy.

@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Nobody worked on this for 6 months (will further age) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants