Allow multiple loadBalancerProviders as the default and for a region #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
|
@lotharbach Thank you for your contribution. |
|
Thank you @lotharbach for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
gardener-robot
added
the
size/m
kon-angelo
reviewed
Sep 30, 2024
|
/reviewed ok-to-test |
gardener-robot
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
|
/needs rebase |
lotharbach
force-pushed
the
allow-multiple-loadBalancerProviders
branch
from
1679f9e
to
650fee3
Compare
Co-authored-by: Konstantinos Angelopoulos <[email protected]>
|
Rebased & thanks for your suggestions @kon-angelo! |
hebelsan
reviewed
Oct 1, 2024
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
kon-angelo
removed
the
needs/ok-to-test
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area networking
/kind enhancement
/platform openstack
What this PR does / why we need it:
We are adding a new openstack region that uses the OVN networking stack, and also the octavia OVN loadbalancer provider that has some worthwhile advantages. But since OVN is also still missing features we want to also allow the well known amphora provider in parallel.
Currently the cloudprofile/controlplane validation does not allow multiple entries for a region.
The Shoot spec validation has always required to specify a loadBalancerProvider even when there is only a single choice, the behavior for a given shoot should stay the same, and the behavior with existing cloudprofiles should also be the same until you add multiple loadBalancerProviders.
Which issue(s) this PR fixes:
Fixes #862
Release note: