-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for VolumeAttributeClasses #862
Open
AndreasBurger
wants to merge
9
commits into
gardener:master
Choose a base branch
from
AndreasBurger:volume-resize
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/storage
Storage related
kind/enhancement
Enhancement, improvement, extension
platform/gcp
Google cloud platform/infrastructure
needs/review
Needs review
size/s
Size of pull request is small (see gardener-robot robot/bots/size.py)
labels
Oct 9, 2024
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Oct 9, 2024
gardener-robot-ci-1
added
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Oct 9, 2024
Currently WIP; with the (currently hardcoded) changes it should work, but I do not have a way to get a 1.31 cluster to fully test yet. So, open todos:
|
AndreasBurger
force-pushed
the
volume-resize
branch
from
October 11, 2024 15:42
65fb691
to
c6202f5
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Oct 11, 2024
AndreasBurger
force-pushed
the
volume-resize
branch
from
October 11, 2024 15:44
c6202f5
to
d161cbc
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Oct 11, 2024
AndreasBurger
force-pushed
the
volume-resize
branch
from
October 17, 2024 15:26
d161cbc
to
8dd4d64
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Oct 17, 2024
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Oct 17, 2024
@AndreasBurger You need rebase this pull request with latest master branch. Please check. |
AndreasBurger
force-pushed
the
volume-resize
branch
from
October 22, 2024 08:37
8dd4d64
to
ee71e2c
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Oct 22, 2024
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Oct 22, 2024
AndreasBurger
force-pushed
the
volume-resize
branch
from
October 22, 2024 08:39
ee71e2c
to
6d1464a
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Oct 22, 2024
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Oct 24, 2024
kon-angelo
previously approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
gardener-robot
added
reviewed/lgtm
Has approval for merging
and removed
needs/changes
Needs (more) changes
needs/rebase
Needs git rebase
needs/review
Needs review
labels
Oct 31, 2024
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Oct 31, 2024
enabled by enabling ControllerModifyVolume functionality via new shoot annotation.
AndreasBurger
force-pushed
the
volume-resize
branch
from
November 4, 2024 15:35
c7f1c09
to
398bd46
Compare
gardener-robot
added
needs/changes
Needs (more) changes
needs/review
Needs review
and removed
needs/review
Needs review
reviewed/lgtm
Has approval for merging
labels
Nov 4, 2024
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Nov 4, 2024
gardener-robot-ci-1
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Nov 4, 2024
hebelsan
reviewed
Nov 4, 2024
gardener-robot-ci-3
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Nov 5, 2024
/hold now requires gardener v1.106 |
gardener-robot
added
the
reviewed/do-not-merge
Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies
label
Nov 5, 2024
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/storage
Storage related
kind/enhancement
Enhancement, improvement, extension
needs/changes
Needs (more) changes
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
platform/gcp
Google cloud platform/infrastructure
reviewed/do-not-merge
Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies
size/s
Size of pull request is small (see gardener-robot robot/bots/size.py)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area storage
/kind enhancement
/platform gcp
What this PR does / why we need it:
With this PR support for volume attributes classes is added by allowing to configure the necessary parameters for it to work.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: