WIP Ingress-gce helm chart #852
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/control-plane
|
@kron4eg Thank you for your contribution. |
gardener-robot
added
needs/review
|
Thank you @kron4eg for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
| verbs: ["get", "list", "watch"] | ||
| # For now, GLBC annotates ingress resources with various state and statuses: | ||
| # https://github.com/kubernetes/ingress-gce/blob/50d49b077d9ab4362a02fae05f94e433cd3f08dc/pkg/controller/controller.go#L579 | ||
| # TODO(rramkumar1): Remove unnecessary `update` permission once statuses are propagated through `ingresses/status` |
There was a problem hiding this comment.
I don't think we need to include the upstream TODOs. Same in l.70
| @@ -5,3 +5,5 @@ cloud-controller-manager: | |||
| enabled: true | |||
| csi-driver-controller: | |||
| enabled: true | |||
| ingress-gce: | |||
| enabled: true | |||
There was a problem hiding this comment.
From what I saw during testing/playing around with this controller, I'd rather not have it enabled by default. In my opinion that should be an option, unless there are cases where it needs to be deployed.
53 tasks
kron4eg
force-pushed
the
ingress-gce-chart
branch
from
6195d5d
to
0881fdb
Compare
gardener-robot
added
kind/api-change
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
kron4eg
force-pushed
the
ingress-gce-chart
branch
2 times, most recently
from
1bea128
to
71f3654
Compare
kron4eg
force-pushed
the
ingress-gce-chart
branch
from
71f3654
to
4926608
Compare
gardener-robot
added
size/l
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/area networking
/kind enhancement
/platform gcp
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: