Sync with upstream `v1.29.4` #327

… to drainability rules

…ity rules

…lity Convert scale-down checks to drainability rules

Update ec2_instance_types with make generate

- HasNodeGroupStartedScaleUp checks wheter a scale up request exists without checking any upcoming nodes.

Add HasNodeGroupStartedScaleUp to cluster state registry.

jbartosik et al are transitioning off of workload autoscalers (incl vpa and addon-resizer). kwiesmueller is on the new team and has agreed to take on reviewer/approver responsibilities.

Add kwiesmueller to OWNERS

…-fix Add information about provisioning-class-name annotation.

Fix multiple run of informers created in fetcher.go

…on't create secret Signed-off-by: Jonathan Raymond <[email protected]>

Signed-off-by: Jonathan Raymond <[email protected]>

Add mechanism to override drainability status

Initialize default drainability rules

…scale from zero method via environment variable The architecture label in the build generic labels method of the cluster API (CAPI) provider is now populated using the GetDefaultScaleFromZeroArchitecture().Name() method. The method allows CAPI users deploying the cluster-autoscaler to define the default architecture to be used by the cluster-autoscaler for scale up from zero via the env var CAPI_SCALE_ZERO_DEFAULT_ARCH. Amd64 is kept as a fallback for historical reasons. The introduced changes will not take into account the case of nodes heterogeneous in architecture. The labels generation to infer properties like the cpu architecture from the node groups' features should be considered as a CAPI provider specific implementation.

…arch The autoscaler does not scale node groups on non-amd64 clusters when pods explicitly require non-amd64 nodes in node affinity

…lti-node-pools-support feat: each node pool can now have different init configs

Some of Cluster Autoscaler code is now using features only available in Go 1.21.

Update image builder to use Go 1.21.3

…ility Signed-off-by: Ayush Rangwala <[email protected]>

… usual

Signed-off-by: Ayush Rangwala <[email protected]>

Adds and implements node taints count metric.

Signed-off-by: Ayush Rangwala <[email protected]>

fix(cluster-autoscaler-chart): if secretKeyRefNameOverride is true, d…

…elay-after-taint-to-faq Add node-delete-delay-after-taint to FAQ

(Price for preemptible instances is calculated as: (Spot price / On-demand price) * instance prices)

Documents startup/status/ignore node taints.

Adding price info for c3d

[cluster-autoscaler] feat: Add equinix metal environment variables and also support older environment variables

Bump CA golang to 1.21

https://portal.exoscale.com/account/limits has been deprecated in favor of https://portal.exoscale.com/organization/quotas. Update README accordingly.

…version

…n-behavior-control-kep-4831 Implementation for KEP-4831: Control VPA eviction behavior based on scaling direction and resource

cloudprovider/exoscale: update limits/quotas URL

Signed-off-by: Thomas Stadler <[email protected]>

kubernetes scheduler.

Fix klog formating directives in cluster-autoscaler package.

Update kubernetes dependencies to 1.29.0-alpha.3.

Signed-off-by: Thomas Stadler <[email protected]>

Remove deprecated dependency: gogo/protobuf

Fixes an issue where the capacityType label inferred from an empty EKS ManagedNodeGroup does not match the same label on the node after it is created and joins the cluster

- Regenerate cloudprovider/externalgrpc proto - go mod tidy

Remove maps.Copy usage.

Signed-off-by: Amir Alavi <[email protected]>

add note for CRD and RBAC handling for VPA (>=1.0.0)

chore: upgrade vpa go and k8s dependencies

Bumps golang from 1.21.2 to 1.21.4. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Disambiguate the resource usage node removal eligibility messages

…g-protobuf-diff Cleanup: Remove deprecated github.com/golang/protobuf usage

Remove RateLimiting options - replay on APF for apiserver protection. Details: kubernetes/kubernetes#111880

…nts-client Cleanup: Remove separate client for k8s events

…ovider-exoscale feat(helm): add support for exoscale provider

Add the AppVersion to labels as app.kubernetes.io/version

Always enable the feature

…vertical-pod-autoscaler/builder/golang-1.21.4 Bump golang from 1.21.2 to 1.21.4 in /vertical-pod-autoscaler/builder

Add Link to Cluster API.

…x-cur-size-of-asg Add min/max/current asg size to log

…ionrequirement-in-readme Add TOC link in README for EvictionRequirement example

Update README.md: Link to Cluster-API

azure: add owner-jackfrancis

Removed node drainer, kept node termination handler

ScaleUp is only ever called when there are unscheduled pods

…chart Template the autoDiscovery.clusterName variable in the Helm chart

Signed-off-by: Matt Dainty <[email protected]>

fix: Add revisionHistoryLimit override to cluster-autoscaler

Fix error in text

allow users to avoid aws instance not found spam

Signed-off-by: Cyrill Troxler <[email protected]>

Update README.md

fix: handle error when listing machines

…torage-support Remove gce-expander-ephemeral-storage-support flag

Allow overriding domain suffix in GCE cloud provider.

Generated by: ``` UPSTREAM_REF=v2.4.0 hack/update-vendor.sh ```

expendable pods Treat non-processed pods yet as unschedulable

…e in naming

… warnings

…processing Ignore scheduler processing

…nts-in-crd Fix '.spec.updatePolicy.evictionRequirements.resources' to be plural in yaml

Reuse k/k resourcehelper func

…ilization Fix: Include restartable init containers in Pod utilization calc

Looks like specifying the Go patch version in go.mod might've been a mistake: kubernetes/kubernetes#121808.

Set Go versions to the same settings kubernetes/kubernetes uses

feat: wip implement `CloudProvider` interface boilerplate for `kwok` provider Signed-off-by: vadasambar <[email protected]> feat: add builder for `kwok` - add logic to scale up and scale down nodes in `kwok` provider Signed-off-by: vadasambar <[email protected]> feat: wip parse node templates from file Signed-off-by: vadasambar <[email protected]> docs: add short README Signed-off-by: vadasambar <[email protected]> feat: implement remaining things - to get the provider in a somewhat working state Signed-off-by: vadasambar <[email protected]> docs: add in-cluster `kwok` as pre-requisite in the README Signed-off-by: vadasambar <[email protected]> fix: templates file not correctly marshalling into node list Signed-off-by: vadasambar <[email protected]> fix: `invalid leading UTF-8 octet` error during template parsing - remove encoding using `gob` - not required Signed-off-by: vadasambar <[email protected]> fix: use lister to get and list - instead of uncached kube client - add lister as a field on the provider and nodegroup struct Signed-off-by: vadasambar <[email protected]> fix: `did not find nodegroup annotation` error - CA was thinking the annotation is not present even though it is - fix a bug with parsing annotation Signed-off-by: vadasambar <[email protected]> fix: CA node recognizing fake nodegroups - add provider ID to nodes in the format `kwok:<node-name>` - fix invalid `KwokManagedAnnotation` - sanitize template nodes (remove `resourceVersion` etc.,) - not sanitizing the node leads to error during creation of new nodes - abstract code to get NG name into a separate function `getNGNameFromAnnotation` Signed-off-by: vadasambar <[email protected]> fix: node not getting deleted Signed-off-by: vadasambar <[email protected]> test: add empty test file Signed-off-by: vadasambar <[email protected]> chore: add OWNERS file Signed-off-by: vadasambar <[email protected]> feat: wip kwok provider config - add samples for static and dynamic template nodes Signed-off-by: vadasambar <[email protected]> feat: wip implement pulling node templates from cluster - add status field to kwok provider config - this is to capture how the nodes would be grouped by (can be annotation or label) - use kwok provider config status to get ng name from the node template Signed-off-by: vadasambar <[email protected]> fix: syntax error in calling `loadNodeTemplatesFromCluster` Signed-off-by: vadasambar <[email protected]> feat: first draft of dynamic node templates - this allows node templates to be pulled from the cluster - instead of having to specify static templates manually Signed-off-by: vadasambar <[email protected]> fix: syntax error Signed-off-by: vadasambar <[email protected]> refactor: abstract out related code into separate files - use named constants instead of hardcoded values Signed-off-by: vadasambar <[email protected]> feat: cleanup kwok nodes when CA is exiting - so that the user doesn't have to cleanup the fake nodes themselves Signed-off-by: vadasambar <[email protected]> refactor: return `nil` instead of err for `HasInstance` - because there is no underlying cloud provider (hence no reason to return `cloudprovider.ErrNotImplemented` Signed-off-by: vadasambar <[email protected]> test: start working on tests for kwok provider config Signed-off-by: vadasambar <[email protected]> feat: add `gpuLabelKey` under `nodes` field in kwok provider config - fix validation for kwok provider config Signed-off-by: vadasambar <[email protected]> docs: add motivation doc - update README with more details Signed-off-by: vadasambar <[email protected]> feat: update kwok provider config example to support pulling gpu labels and types from existing providers - still needs to be implemented in the code Signed-off-by: vadasambar <[email protected]> feat: wip update kwok provider config to get gpu label and available types Signed-off-by: vadasambar <[email protected]> feat: wip read gpu label and available types from specified provider - add available gpu types in kwok provider config status Signed-off-by: vadasambar <[email protected]> feat: add validation for gpu fields in kwok provider config - load gpu related fields in kwok provider config status Signed-off-by: vadasambar <[email protected]> feat: implement `GetAvailableGPUTypes` Signed-off-by: vadasambar <[email protected]> feat: add support to install and uninstall kwok - add option to disable installation - add option to manually specify kwok release tag - add future scope in readme Signed-off-by: vadasambar <[email protected]> docs: add future scope 'evaluate adding support to check if kwok controller already exists' Signed-off-by: vadasambar <[email protected]> fix: vendor conflict and cyclic import - remove support to get gpu config from the specified provider (can't be used because leads to cyclic import) Signed-off-by: vadasambar <[email protected]> docs: add a TODO 'get gpu config from other providers' Signed-off-by: vadasambar <[email protected]> refactor: rename `file` -> `configmap` - load config and templates from configmap instead of file - move `nodes` and `nodegroups` config to top level - add helper to encode configmap data into `[]bytes` - add helper to get current pod namespace Signed-off-by: vadasambar <[email protected]> feat: add new options to the kwok provider config - auto install kwok only if the version is >= v0.4.0 - add test for `GPULabel()` - use `kubectl apply` way of installing kwok instead of kustomize - add test for kwok helpers - add test for kwok config - inject service account name in CA deployment - add example configmap for node templates and kwok provider config in CA helm chart - add permission to create `clusterrolebinding` (so that kwok provider can create a clusterrolebinding with `cluster-admin` role and create/delete upstream manifests) - update kwok provider sample configs - update `README` Signed-off-by: vadasambar <[email protected]> chore: update go.mod to use v1.28 packages Signed-off-by: vadasambar <[email protected]> chore: `go mod tidy` and `go mod vendor` (again) Signed-off-by: vadasambar <[email protected]> refactor: kwok installation code - add functions to create and delete clusterrolebinding to create kwok resources - refactor kwok install and uninstall fns - delete manifests in the opposite order of install ] - add cleaning up left-over kwok installation to future scope Signed-off-by: vadasambar <[email protected]> fix: nil ptr error - add `TODO` in README for adding docs around kwok config fields Signed-off-by: vadasambar <[email protected]> refactor: remove code to automatically install and uninstall `kwok` - installing/uninstalling requires strong permissions to be granted to `kwok` - granting strong permissions to `kwok` means granting strong permissions to the entire CA codebase - this can pose a security risk - I have removed the code related to install and uninstall for now - will proceed after discussion with the community Signed-off-by: vadasambar <[email protected]> chore: run `go mod tidy` and `go mod vendor` Signed-off-by: vadasambar <[email protected]> fix: add permission to create nodes - to fix permissions error for kwok provider Signed-off-by: vadasambar <[email protected]> test: add more unit tests - add tests for kwok helpers - fix and update kwok config tests - fix a bug where gpu label was getting assigned to `kwokConfig.status.key` - expose `loadConfigFile` -> `LoadConfigFile` - throw error if templates configmap does not have `templates` key (value of which is node templates) - finish test for `GPULabel()` - add tests for `NodeGroupForNode()` - expose `loadNodeTemplatesFromConfigMap` -> `LoadNodeTemplatesFromConfigMap` - fix `KwokCloudProvider`'s kwok config was empty (this caused `GPULabel()` to return empty) Signed-off-by: vadasambar <[email protected]> refactor: abstract provider ID code into `getProviderID` fn - fix provider name in test `kwok` -> `kwok:kind-worker-xxx` Signed-off-by: vadasambar <[email protected]> chore: run `go mod vendor` and `go mod tidy Signed-off-by: vadasambar <[email protected]> docs(cloudprovider/kwok): update info on creating nodegroups based on `hostname/label` Signed-off-by: vadasambar <[email protected]> refactor(charts): replace fromLabelKey value `"kubernetes.io/hostname"` -> `"kwok-nodegroup"` - `"kubernetes.io/hostname"` leads to infinite scale-up Signed-off-by: vadasambar <[email protected]> feat: support running CA with kwok provider locally Signed-off-by: vadasambar <[email protected]> refactor: use global informer factory Signed-off-by: vadasambar <[email protected]> refactor: use `fromNodeLabelKey: "kwok-nodegroup"` in test templates Signed-off-by: vadasambar <[email protected]> refactor: `Cleanup()` logic - clean up only nodes managed by the kwok provider Signed-off-by: vadasambar <[email protected]> fix/refactor: nodegroup creation logic - fix issue where fake node was getting created which caused fatal error - use ng annotation to keep track of nodegroups - (when creating nodegroups) don't process nodes which don't have the right ng nabel - suffix ng name with unix timestamp Signed-off-by: vadasambar <[email protected]> refactor/test(cloudprovider/kwok): write tests for `BuildKwokProvider` and `Cleanup` - pass only the required node lister to cloud provider instead of the entire informer factory - pass the required configmap name to `LoadNodeTemplatesFromConfigMap` instead of passing the entire kwok provider config - implement fake node lister for testing Signed-off-by: vadasambar <[email protected]> test: add test case for dynamic templates in `TestNodeGroupForNode` - remove non-required fields from template node Signed-off-by: vadasambar <[email protected]> test: add tests for `NodeGroups()` - add extra node template without ng selector label to add more variability in the test Signed-off-by: vadasambar <[email protected]> test: write tests for `GetNodeGpuConfig()` Signed-off-by: vadasambar <[email protected]> test: add test for `GetAvailableGPUTypes` Signed-off-by: vadasambar <[email protected]> test: add test for `GetResourceLimiter()` Signed-off-by: vadasambar <[email protected]> test(cloudprovider/kwok): add tests for nodegroup's `IncreaseSize()` - abstract error msgs into variables to use them in tests Signed-off-by: vadasambar <[email protected]> test(cloudprovider/kwok): add test for ng `DeleteNodes()` fn - add check for deleting too many nodes - rename err msg var names to make them consistent Signed-off-by: vadasambar <[email protected]> test(cloudprovider/kwok): add tests for ng `DecreaseTargetSize()` - abstract error msgs into variables (for easy use in tests) Signed-off-by: vadasambar <[email protected]> test(cloudprovider/kwok): add test for ng `Nodes()` - add extra test case for `DecreaseTargetSize()` to check lister error Signed-off-by: vadasambar <[email protected]> test(cloudprovider/kwok): add test for ng `TemplateNodeInfo` Signed-off-by: vadasambar <[email protected]> test(cloudprovider/kwok): improve tests for `BuildKwokProvider()` - add more test cases - refactor lister for `TestBuildKwokProvider()` and `TestCleanUp()` Signed-off-by: vadasambar <[email protected]> test(cloudprovider/kwok): add test for ng `GetOptions` Signed-off-by: vadasambar <[email protected]> test(cloudprovider/kwok): unset `KWOK_CONFIG_MAP_NAME` at the end of the test - not doing so leads to failure in other tests - remove `kwokRelease` field from kwok config (not used anymore) - this was causing the tests to fail Signed-off-by: vadasambar <[email protected]> chore: bump CA chart version - this is because of changes made related to kwok - fix type `everwhere` -> `everywhere` Signed-off-by: vadasambar <[email protected]> chore: fix linting checks Signed-off-by: vadasambar <[email protected]> chore: address CI lint errors Signed-off-by: vadasambar <[email protected]> chore: generate helm docs for `kwokConfigMapName` - remove `KWOK_CONFIG_MAP_KEY` (not being used in the code) - bump helm chart version Signed-off-by: vadasambar <[email protected]> docs: revise the outline for README - add AEP link to the motivation doc Signed-off-by: vadasambar <[email protected]> docs: wip create an outline for the README - remove `kwok` field from examples (not needed right now) Signed-off-by: vadasambar <[email protected]> docs: add outline for ascii gifs Signed-off-by: vadasambar <[email protected]> refactor: rename env variable `KWOK_CONFIG_MAP_NAME` -> `KWOK_PROVIDER_CONFIGMAP` Signed-off-by: vadasambar <[email protected]> docs: update README with info around installation and benefits of using kwok provider - add `Kwok` as a provider in main CA README Signed-off-by: vadasambar <[email protected]> chore: run `go mod vendor` - remove TODOs that are not needed anymore Signed-off-by: vadasambar <[email protected]> docs: finish first draft of README Signed-off-by: vadasambar <[email protected]> fix: env variable in chart `KWOK_CONFIG_MAP_NAME` -> `KWOK_PROVIDER_CONFIGMAP` Signed-off-by: vadasambar <[email protected]> refactor: remove redundant/deprecated code Signed-off-by: vadasambar <[email protected]> chore: bump chart version `9.30.1` -> `9.30.2` - because of kwok provider related changes Signed-off-by: vadasambar <[email protected]> chore: fix typo `offical` -> `official` Signed-off-by: vadasambar <[email protected]> chore: remove debug log msg Signed-off-by: vadasambar <[email protected]> docs: add links for getting help Signed-off-by: vadasambar <[email protected]> refactor: fix type in log `external cluster` -> `cluster` Signed-off-by: vadasambar <[email protected]> chore: add newline in chart.yaml to fix CI lint Signed-off-by: vadasambar <[email protected]> docs: fix mistake `sig-kwok` -> `sig-scheduling` - kwok is a part if sig-scheduling (there is no sig-kwok) Signed-off-by: vadasambar <[email protected]> docs: fix type `release"` -> `"release"` Signed-off-by: vadasambar <[email protected]> refactor: pass informer instead of lister to cloud provider builder fn Signed-off-by: vadasambar <[email protected]>

Implement ProvisioningRequest service

feat: implement `kwok` cloud provider

Signed-off-by: Jack Francis <[email protected]>

chore(deps): update vendored hcloud-go to 2.4.0

Signed-off-by: Vishal Anarse <[email protected]>

(cherry picked from commit b9f636d) Signed-off-by: qianlei.qianl <[email protected]> refactor: move logic to create client to utils/kubernetes pkg - expose `CreateKubeClient` as public function - make `GetKubeConfig` into a private `getKubeConfig` function (can be exposed as a public function in the future if needed) Signed-off-by: vadasambar <[email protected]> fix: CI failing because cloudproviders were not updated to use new autoscaling option fields Signed-off-by: vadasambar <[email protected]> refactor: define errors as constants Signed-off-by: vadasambar <[email protected]> refactor: pass kube client options by value Signed-off-by: vadasambar <[email protected]>

…emplate Implement TemplateNodeInfo for civo cloudprovider

Signed-off-by: Vishal Anarse <[email protected]>

refactor(*): move getKubeClient to utils/kubernetes

fix: alicloud the function NodeGroupForNode return nil

…de-template [civo] Calculate real value for template using node group

Remove *_test.go, models/, examples

+ Update version in README + command

…ache-instance-requirements AWS: cache instance requirements

Fix capacityType label in AWS ManagedNodeGroup

…deprecate Azure: Remove AKS vmType

Update cloudprovider/aws/aws-sdk-go to 1.48.7

Fixes scale down logic.

Update AWS instance list - Dec 2023

Helm: update cluster-autoscaler to 1.28

…age-build Switch to multistage build Dockerfiles for VPA

…d-node-group-count flags Signed-off-by: Prashant Rewar <[email protected]>

The Hetzner Cloud API returns "Actions" for anything asynchronous that happens inside the backend. When creating a new server multiple actions are returned: `create_server`, `start_server`, `attach_to_network` (if set). Our current code waits for the `create_server` and if it fails, it makes sure to delete the server so cluster-autoscaler can create a new one immediately to provide the required capacity. If one of the "follow up" actions fails though, we do not handle this. This causes issues when the server for whatever reason did not start properly on the first try, as then the customer has a shutdown server, is paying for it, but does not receive the additional capacity for their Kubernetes cluster. This commit fixes the bug, by awaiting all actions returned by the create server API call, and deleting the server if any of them fail.

…actions fix(hetzner): insufficient nodes when boot fails

…aler-annotation-ignore fix: update node annotation used to limit log spam with valid key

feat: add metrics to show target size of every node group

…iles

fix: updated readme for hetzner cloud provider

Change-Id: I3b5c62ba13c2e048ce2d7170016af07182c11eee

Add error details to autoscaling backoff.

Change-Id: I1f812d4d6f42db97670ef7304fc0e895c837a13b

Make backoff.Status.ErrorInfo non-pointer.

…d-flag Deprecate unused node-autoprovisioning-enabled and max-autoprovisioned-node-group-count flags

Signed-off-by: lizhen <[email protected]>

[GCE] Support paginated instance listing

allow specifing grpc timeout rather than hardcoded 5 seconds

Signed-off-by: Jack Francis <[email protected]>

Remove vpa builder Dockerfile and switch dependabot to component Dockerfiles

…ks-deprecate azure: fix chart bugs after AKS vmType deprecation

Add VSCode workspace files to .gitignore

Implement priority based evictor

Update VPA release README to reference 1.X VPA versions.

…r-release-1.29 Update dependencies to kubernetes 1.29.0

Signed-off-by: Vishal Anarase <[email protected]> (cherry picked from commit 8703ff9)

…ler-release-1.29 Backport of kubernetes#6390

Partially undo kubernetes#6274. I noticed that with this change CA get rate limited and slows down significantly (especially during large scale downs).

…miting Restore flags for setting QPS limit in CA

Pass Burst and QPS client params to capi k8s clients 1.29

Dependency update for CA 1.29.1

Signed-off-by: vadasambar <[email protected]> feat: update scale down status after every scale up - move scaledown delay status to cluster state/registry - enable scale down if `ScaleDownDelayTypeLocal` is enabled - add new funcs on cluster state to get and update scale down delay status - use timestamp instead of booleans to track scale down delay status Signed-off-by: vadasambar <[email protected]> refactor: use existing fields on clusterstate - uses `scaleUpRequests`, `scaleDownRequests` and `scaleUpFailures` instead of `ScaleUpDelayStatus` - changed the above existing fields a little to make them more convenient for use - moved initializing scale down delay processor to static autoscaler (because clusterstate is not available in main.go) Signed-off-by: vadasambar <[email protected]> refactor: remove note saying only `scale-down-after-add` is supported - because we are supporting all the flags Signed-off-by: vadasambar <[email protected]> fix: evaluate `scaleDownInCooldown` the old way only if `ScaleDownDelayTypeLocal` is set to `false` Signed-off-by: vadasambar <[email protected]> refactor: remove line saying `--scale-down-delay-type-local` is only supported for `--scale-down-delay-after-add` - because it is not true anymore - we are supporting all `--scale-down-delay-after-*` flags per nodegroup Signed-off-by: vadasambar <[email protected]> test: fix clusterstate tests failing Signed-off-by: vadasambar <[email protected]> refactor: move back initializing processors logic to from static autoscaler to main - we don't want to initialize processors in static autoscaler because anyone implementing an alternative to static_autoscaler has to initialize the processors - and initializing specific processors is making static autoscaler aware of an implementation detail which might not be the best practice Signed-off-by: vadasambar <[email protected]> refactor: revert changes related to `clusterstate` - since I am going with observer pattern Signed-off-by: vadasambar <[email protected]> feat: add observer interface for state of scaling - to implement observer pattern for tracking state of scale up/downs (as opposed to using clusterstate to do the same) - refactor `ScaleDownCandidatesDelayProcessor` to use fields from the new observer Signed-off-by: vadasambar <[email protected]> refactor: remove params passed to `clearScaleUpFailures` - not needed anymore Signed-off-by: vadasambar <[email protected]> refactor: revert clusterstate tests - approach has changed - I am not making any changes in clusterstate now Signed-off-by: vadasambar <[email protected]> refactor: add accidentally deleted lines for clusterstate test Signed-off-by: vadasambar <[email protected]> feat: implement `Add` fn for scale state observer - to easily add new observers - re-word comments - remove redundant params from `NewDefaultScaleDownCandidatesProcessor` Signed-off-by: vadasambar <[email protected]> fix: CI complaining because no comments on fn definitions Signed-off-by: vadasambar <[email protected]> feat: initialize parent `ScaleDownCandidatesProcessor` - instead of `ScaleDownCandidatesSortingProcessor` and `ScaleDownCandidatesDelayProcessor` separately Signed-off-by: vadasambar <[email protected]> refactor: add scale state notifier to list of default processors - initialize processors for `NewDefaultScaleDownCandidatesProcessor` outside and pass them to the fn - this allows more flexibility Signed-off-by: vadasambar <[email protected]> refactor: add observer interface - create a separate observer directory - implement `RegisterScaleUp` function in the clusterstate - TODO: resolve syntax errors Signed-off-by: vadasambar <[email protected]> feat: use `scaleStateNotifier` in place of `clusterstate` - delete leftover `scale_stateA_observer.go` (new one is already present in `observers` directory) - register `clustertstate` with `scaleStateNotifier` - use `Register` instead of `Add` function in `scaleStateNotifier` - fix `go build` - wip: fixing tests Signed-off-by: vadasambar <[email protected]> test: fix syntax errors - add utils package `pointers` for converting `time` to pointer (without having to initialize a new variable) Signed-off-by: vadasambar <[email protected]> feat: wip track scale down failures along with scale up failures - I was tracking scale up failures but not scale down failures - fix copyright year 2017 -> 2023 for the new `pointers` package Signed-off-by: vadasambar <[email protected]> feat: register failed scale down with scale state notifier - wip writing tests for `scale_down_candidates_delay_processor` - fix CI lint errors - remove test file for `scale_down_candidates_processor` (there is not much to test as of now) Signed-off-by: vadasambar <[email protected]> test: wip tests for `ScaleDownCandidatesDelayProcessor` Signed-off-by: vadasambar <[email protected]> test: add unit tests for `ScaleDownCandidatesDelayProcessor` Signed-off-by: vadasambar <[email protected]> refactor: don't track scale up failures in `ScaleDownCandidatesDelayProcessor` - not needed Signed-off-by: vadasambar <[email protected]> test: better doc comments for `TestGetScaleDownCandidates` Signed-off-by: vadasambar <[email protected]> refactor: don't ignore error in `NGChangeObserver` - return it instead and let the caller decide what to do with it Signed-off-by: vadasambar <[email protected]> refactor: change pointers to values in `NGChangeObserver` interface - easier to work with - remove `expectedAddTime` param from `RegisterScaleUp` (not needed for now) - add tests for clusterstate's `RegisterScaleUp` Signed-off-by: vadasambar <[email protected]> refactor: conditions in `GetScaleDownCandidates` - set scale down in cool down if the number of scale down candidates is 0 Signed-off-by: vadasambar <[email protected]> test: use `ng1` instead of `ng2` in existing test Signed-off-by: vadasambar <[email protected]> feat: wip static autoscaler tests Signed-off-by: vadasambar <[email protected]> refactor: assign directly instead of using `sdProcessor` variable - variable is not needed Signed-off-by: vadasambar <[email protected]> test: first working test for static autoscaler Signed-off-by: vadasambar <[email protected]> test: continue working on static autoscaler tests Signed-off-by: vadasambar <[email protected]> test: wip second static autoscaler test Signed-off-by: vadasambar <[email protected]> refactor: remove `Println` used for debugging Signed-off-by: vadasambar <[email protected]> test: add static_autoscaler tests for scale down delay per nodegroup flags Signed-off-by: vadasambar <[email protected]> chore: rebase off the latest `master` - change scale state observer interface's `RegisterFailedScaleup` to reflect latest changes around clusterstate's `RegisterFailedScaleup` in `master` Signed-off-by: vadasambar <[email protected]> test: fix clusterstate test failing Signed-off-by: vadasambar <[email protected]> test: fix failing orchestrator test Signed-off-by: vadasambar <[email protected]> refactor: rename `defaultScaleDownCandidatesProcessor` -> `combinedScaleDownCandidatesProcessor` - describes the processor better Signed-off-by: vadasambar <[email protected]> refactor: replace `NGChangeObserver` -> `NodeGroupChangeObserver` - makes it easier to understand for someone not familiar with the codebase Signed-off-by: vadasambar <[email protected]> docs: reword code comment `after` -> `for which` Signed-off-by: vadasambar <[email protected]> refactor: don't return error from `RegisterScaleDown` - not needed as of now (no implementer function returns a non-nil error for this function) Signed-off-by: vadasambar <[email protected]> refactor: address review comments around ng change observer interface - change dir structure of nodegroup change observer package - stop returning errors wherever it is not needed in the nodegroup change observer interface - rename `NGChangeObserver` -> `NodeGroupChangeObserver` interface (makes it easier to understand) Signed-off-by: vadasambar <[email protected]> refactor: make nodegroupchange observer thread-safe Signed-off-by: vadasambar <[email protected]> docs: add TODO to consider using multiple mutexes in nodegroupchange observer Signed-off-by: vadasambar <[email protected]> refactor: use `time.Now()` directly instead of assigning a variable to it Signed-off-by: vadasambar <[email protected]> refactor: share code for checking if there was a recent scale-up/down/failure Signed-off-by: vadasambar <[email protected]> test: convert `ScaleDownCandidatesDelayProcessor` into table tests Signed-off-by: vadasambar <[email protected]> refactor: change scale state notifier's `Register()` -> `RegisterForNotifications()` - makes it easier to understand what the function does Signed-off-by: vadasambar <[email protected]> test: replace scale state notifier `Register` -> `RegisterForNotifications` in test - to fix syntax errors since it is already renamed in the actual code Signed-off-by: vadasambar <[email protected]> refactor: remove `clusterStateRegistry` from `delete_in_batch` tests - not needed anymore since we have `scaleStateNotifier` Signed-off-by: vadasambar <[email protected]> refactor: address PR review comments Signed-off-by: vadasambar <[email protected]> fix: add empty `RegisterFailedScaleDown` for clusterstate - fix syntax error in static autoscaler test Signed-off-by: vadasambar <[email protected]> (cherry picked from commit 5de49a1)

…nt to the CloudProviders builder into CA1.29

…494_and_#6491-upstream-cluster-autoscaler-release-1.29 Backport kubernetes#6491 and kubernetes#6494 [CA] Add informer argument to the Cloud Providers builder into CA1.29

ionoscloud: Update ionos-cloud sdk-go and add metrics

…1.29 Backport kubernetes#6617 ionoscloud: Update ionos-cloud sdk-go and add metrics into CA 1.29

…522-upstream-cluster-autoscaler-release-1.29 Backport kubernetes#6522 [CA] Bump go version into CA1.29

…scale-down-delay-per-ng-1.29 chore: cherry-pick scale-down-delay-* per nodegroup to 1.29

…r-1.29-vendor-update CA - Update k/k vendor to 1.29.3 for 1.29 Release Branch

This fixed requests for pods with ephemeral storage requests being denied due to insufficient ephemeral storage for the Hetzner provider. Backport of kubernetes#6574 to `v1.29` branch.

…l-storage-1.29 [v1.29][Hetzner] Fix missing ephemeral storage definition

[Azure VMs Pool] Support mixed agentpool types in Azure Cache

…erID This change fixes a bug that arises when the user's cluster includes worker nodes not from Hetzner Cloud, such as a Hetzner Dedicated server or any server resource other than Hetzner. It also corrects the behavior when a server has been physically deleted from Hetzner Cloud. Signed-off-by: Maksim Paskal <[email protected]>

…providerid-1.29 [v1.29][Hetzner] Fix Autoscaling for worker nodes with invalid ProviderID

The Node Group info we currently return does not include the `kubernetes.io/hostname` label, which is usually set on every node. This causes issues when the user has an unscheduled pod with a `topologySpreadConstraint` on `topologyKey: kubernetes.io/hostname`. cluster-autoscaler is unable to fulfill this constraint and does not scale up any of the node groups. Related to kubernetes#6715

…hostname-labels-1.29 [v1.29] fix(hetzner): hostname label is not considered

[CA 1.29 kubernetes#6596 cherry-pick] Remove shadow err variable in deleteCreatedNodesWithErros func

…ons() Properly handle calls to `NodeGroup.GetOptions()` that return `cloudprovider.ErrNotImplemented` in the scale up path.

[CA 1.29 kubernetes#6677 cherry-pick] fix: scale up broken for providers not implementing NodeGroup.GetOptions()

…er-release-1.29 Update k/k vendor to 1.29.5 for CA 1.29

…nces with nil status into CA1.29

…528-upstream-cluster-autoscaler-release-1.29 Backport kubernetes#6528 [CA] Fix expectedToRegister to respect instances with nil status into CA1.29

…-config [Azure VMs pool] Introducing agentpool client

…cale up/down into CA1.29

…#5829

…750-upstream-cluster-autoscaler-release-1.29 Backport kubernetes#6750 [CA] fix(hetzner): missing error return in scale up/down into CA 1.29

…elease-1.29 PR#6911 Backport for 1.29: Fix/aws asg unsafe decommission kubernetes#5829

…ce-Update CA - 1.29.4 Pre-release AWS Instance Types Update

…se-1.29 Update vendor to use k8s 1.29.6

Commits on Nov 19, 2023

Update README.md

Fix error in text

AlexanderSerbul authored Nov 19, 2023

Configuration menu

View commit details

Copy full SHA for 0b8bc74

Browse repository at this point

Copy the full SHA

0b8bc74 View commit details

Browse the repository at this point in the history

Commits on Mar 19, 2024

CA - Update k/k vendor to 1.29.3

gjtempleton committed Mar 19, 2024

Configuration menu

View commit details

Copy full SHA for 23b5eb8

Browse repository at this point

Copy the full SHA

23b5eb8 View commit details

Browse the repository at this point in the history

Commits on May 30, 2024

Rename ARM_BASE_URL

wenxuan0923 committed May 30, 2024

Configuration menu

View commit details

Copy full SHA for 5e379e4

Browse repository at this point

Copy the full SHA

5e379e4 View commit details

Browse the repository at this point in the history

Sync with upstream v1.29.4 #327

Sync with upstream v1.29.4 #327

Commits on Oct 10, 2023

Commits on Oct 11, 2023

Commits on Oct 12, 2023

Commits on Oct 13, 2023

Commits on Oct 16, 2023

Commits on Oct 17, 2023

Commits on Oct 18, 2023

Commits on Oct 19, 2023

Commits on Oct 20, 2023

Commits on Oct 23, 2023

Commits on Oct 24, 2023

Commits on Oct 26, 2023

Commits on Oct 30, 2023

Commits on Oct 31, 2023

Commits on Nov 2, 2023

Commits on Nov 3, 2023

Commits on Nov 4, 2023

Commits on Nov 6, 2023

Commits on Nov 7, 2023

Commits on Nov 8, 2023

Commits on Nov 9, 2023

Commits on Nov 10, 2023

Commits on Nov 14, 2023

Commits on Nov 15, 2023

Commits on Nov 16, 2023

Commits on Nov 17, 2023

Commits on Nov 18, 2023

Commits on Nov 19, 2023

Commits on Nov 20, 2023

Commits on Nov 21, 2023

Commits on Nov 22, 2023

Commits on Nov 23, 2023

Commits on Nov 24, 2023

Commits on Nov 26, 2023

Commits on Nov 27, 2023

Commits on Nov 28, 2023

Commits on Nov 29, 2023

Commits on Nov 30, 2023

Commits on Dec 4, 2023

Commits on Dec 5, 2023

Commits on Dec 6, 2023

Commits on Dec 8, 2023

Commits on Dec 9, 2023

Commits on Dec 11, 2023

Commits on Dec 12, 2023

Commits on Dec 13, 2023

Commits on Dec 14, 2023

Commits on Dec 15, 2023

Commits on Dec 19, 2023

Commits on Dec 20, 2023

Commits on Dec 21, 2023

Commits on Dec 22, 2023

Commits on Dec 27, 2023

Commits on Dec 28, 2023

Commits on Dec 29, 2023

Commits on Jan 10, 2024

Commits on Jan 23, 2024

Commits on Jan 30, 2024

Commits on Feb 12, 2024

Commits on Mar 6, 2024

Commits on Mar 7, 2024

Commits on Mar 13, 2024

Commits on Mar 14, 2024

Commits on Mar 15, 2024

Commits on Mar 18, 2024

Commits on Mar 19, 2024

Commits on Mar 20, 2024

Commits on Apr 2, 2024

Commits on Apr 4, 2024

Commits on Apr 5, 2024

Commits on Apr 9, 2024

Commits on Apr 12, 2024

Commits on Apr 17, 2024

Commits on Apr 18, 2024

Commits on Apr 24, 2024

Commits on May 27, 2024

Commits on May 28, 2024

Commits on May 29, 2024

Sync with upstream `v1.29.4` #327

Sync with upstream `v1.29.4` #327