VPA: Fix the pipeline definition to use the upstream Dockerfiles #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ialidzhikov
requested review from
himanshu-kun,
unmarshall,
rishabh-11 and
a team
as code owners
gardener-robot
added
needs/review
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Co-authored-by: plkokanov <[email protected]> Co-authored-by: AndreasBurgeer <[email protected]>
ialidzhikov
force-pushed
the
fix/pipeline-definition
branch
from
676bfe8
to
11b3e98
Compare
gardener-robot
added
reviewed/lgtm
plkokanov
merged commit 85cd617
into
gardener:rel-vertical-pod-autoscaler
5 checks passed
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The golang version is outdated in the
vertical-pod-autoscaler/Dockerfile.{admissioncontroller,recommdener,updater}. This PR switches the release job to use the upstream Dockerfiles underpkg/{admission-controller,recommdener,updater}/Dockerfilewhich are multi-stage ones as well.Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A
Release note: